Uh oh!
There was an error while loading. Please reload this page.
test: replace forEach() in test-net-perf_hooks with for of - #49831
Merged
nodejs-github-bot merged 1 commit intoOct 6, 2023
Conversation
lpinca
approved these changes
Sep 23, 2023
narcisacodreanuforce-pushed
the
replace-foreach-in-tests
branch
from
September 24, 2023 17:01
518342d to
1de9402Comparenarcisacodreanuforce-pushed
the
replace-foreach-in-tests
branch
from
September 24, 2023 21:36
1de9402 to
c3cdaa7Comparetrivikr
approved these changes
Sep 25, 2023
narcisacodreanu
commented
Sep 25, 2023
ContributorAuthor
hi @lpinca and @trivikr, thanks for approving this PR! Would you be able to point me to what the next steps would be to move it forward? This is my first contribution to node and I'm not sure how to go about landing the PR and merging it (https://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md#step-10-landing) |
joesepi
approved these changes
Sep 25, 2023
narcisacodreanu
commented
Oct 5, 2023
ContributorAuthor
Hi @tniessen let me know if you have any advice on the next steps to move the PR forward. This was part of the Open Source Day event for GHC. Much appreciated, thanks! |
tniessen
commented
Oct 5, 2023
Member
@narcisacodreanu Apologies for the delay on our end. Once CI passes (which might take a while), this is good to go! |
tniessen
approved these changes
Oct 5, 2023
This comment was marked as outdated.
This comment was marked as outdated.
10 tasks
nodejs-github-bot
commented
Oct 6, 2023
Collaborator
nodejs-github-bot
commented
Oct 6, 2023
Collaborator
Landed in 2fe511b |
tniessen
commented
Oct 6, 2023
Member
Thank you for the contribution @narcisacodreanu! |
This was referenced Oct 7, 2023
narcisacodreanu
commented
Oct 9, 2023
ContributorAuthor
Yaay, thank you for your help @tniessen!! |
24 tasks
targos pushed a commit
that referenced
this pull request
Nov 11, 2023
PR-URL: #49831 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Joe Sepi <sepi@joesepi.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
debadree25 pushed a commit
to debadree25/node
that referenced
this pull request
Apr 15, 2024
PR-URL: nodejs#49831 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Joe Sepi <sepi@joesepi.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the use of
forEach()intest-net-perf_hooks.jsby replacing it withfor ... of(Part of Open Source Day at GHC 2023)