fs: improve error performance for `mkdirSync` by CanadaHonk · Pull Request #49847 · nodejs/node

CanadaHonk · 2023-09-25T05:20:01Z

Results from i7 Windows laptop:

 confidence improvement accuracy (*) (**) (***)
fs\bench-mkdirSync.js n=1000 recursive='false' type='existing' *** 66.99 % ±3.62% ±4.85% ±6.38%
fs\bench-mkdirSync.js n=1000 recursive='false' type='non-existing' 3.40 % ±4.02% ±5.35% ±6.96%
fs\bench-mkdirSync.js n=1000 recursive='true' type='existing' 4.32 % ±5.81% ±7.76% ±10.16%
fs\bench-mkdirSync.js n=1000 recursive='true' type='non-existing' * 3.36 % ±2.72% ±3.62% ±4.71%

Ref: nodejs/performance#106

CanadaHonk · 2023-09-25T12:13:49Z

Updated to fix all review comments, thanks!

nodejs-github-bot · 2023-09-25T12:20:14Z

CI: https://ci.nodejs.org/job/node-test-pull-request/54210/

nodejs-github-bot · 2023-09-25T19:17:33Z

CI: https://ci.nodejs.org/job/node-test-pull-request/54231/

CanadaHonk · 2023-09-25T22:57:41Z

Flaky CI?

nodejs-github-bot · 2023-09-25T23:09:51Z

CI: https://ci.nodejs.org/job/node-test-pull-request/54238/

CanadaHonk · 2023-09-26T00:48:53Z

Broken (empty?) CI again?

CanadaHonk · 2023-09-26T00:56:10Z

Rebased on latest main to fix merge conflict.

nodejs-github-bot · 2023-09-26T01:34:47Z

CI: https://ci.nodejs.org/job/node-test-pull-request/54242/

nodejs-github-bot · 2023-09-26T15:45:25Z

CI: https://ci.nodejs.org/job/node-test-pull-request/54255/

anonrig · 2023-09-27T13:32:05Z

@CanadaHonk can you resolve the conflicts?

joyeecheung · 2023-10-02T13:31:47Z

#49913 has landed. Can you move the JS code back to lib/fs.js and switch to use SyncCallAndThrowOnError in the original implementation instead of introducing a new binding? Thanks.

nodejs-github-bot · 2023-10-11T18:44:36Z

CI: https://ci.nodejs.org/job/node-test-pull-request/54711/

nodejs-github-bot · 2023-10-11T19:35:04Z

CI: https://ci.nodejs.org/job/node-test-pull-request/54717/

nodejs-github-bot · 2023-10-17T18:01:23Z

CI: https://ci.nodejs.org/job/node-test-pull-request/54898/

nodejs-github-bot · 2023-10-19T15:32:57Z

CI: https://ci.nodejs.org/job/node-test-pull-request/55006/

nodejs-github-bot · 2023-10-20T23:39:04Z

Landed in c37cf18

PR-URL: #49847 Refs: nodejs/performance#106 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Sep 25, 2023

anonrig reviewed Sep 25, 2023
View reviewed changes

Comment threadsrc/node_file.cc Outdated
Comment threadsrc/node_file.cc Outdated
Comment threadsrc/node_file.cc Outdated

anonrig approved these changes Sep 25, 2023
View reviewed changes

anonrig added performance Issues and PRs related to the performance of Node.js. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 25, 2023

anonrig mentioned this pull request Sep 25, 2023
Performance of node:fsnodejs/performance#106
Open

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2023

anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2023

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2023

CanadaHonk force-pushed the perf-mkdirsync branch from 66f03f6 to b68c5d8Compare September 26, 2023 00:52

anonrig approved these changes Sep 26, 2023
View reviewed changes

anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 26, 2023

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 26, 2023

github-actionsBot mentioned this pull request Sep 27, 2023
CI Reliability 2023-09-27 nodejs/reliability#676
Open
21 tasks

anonrig added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 27, 2023

anonrig force-pushed the perf-mkdirsync branch from fe28c76 to 92b3a70Compare October 11, 2023 18:26

anonrig added request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Oct 11, 2023

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 11, 2023

anonrig force-pushed the perf-mkdirsync branch from 92b3a70 to b826f39Compare October 11, 2023 19:18

anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 11, 2023

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 11, 2023

joyeecheung reviewed Oct 12, 2023
View reviewed changes

Comment threadsrc/node_file.cc Outdated

anonrig force-pushed the perf-mkdirsync branch from b826f39 to 6b3b154Compare October 12, 2023 15:11

fs: improve error performance for mkdirSync
569c96b

anonrig force-pushed the perf-mkdirsync branch from 6b3b154 to 569c96bCompare October 15, 2023 16:58

anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 17, 2023

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 17, 2023

github-actionsBot mentioned this pull request Oct 19, 2023
CI Reliability 2023-10-19 nodejs/reliability#691
Open
25 tasks

joyeecheung approved these changes Oct 19, 2023
View reviewed changes

anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 20, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 20, 2023

nodejs-github-bot merged commit c37cf18 into nodejs:mainOct 20, 2023

targos pushed a commit that referenced this pull request Oct 23, 2023
fs: improve error performance for mkdirSync
6ec5aba
PR-URL: #49847 Refs: nodejs/performance#106 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

targos mentioned this pull request Oct 23, 2023
v21.1.0 release proposal #50335
Merged

targos pushed a commit that referenced this pull request Nov 11, 2023
fs: improve error performance for mkdirSync
8d0edc6
PR-URL: #49847 Refs: nodejs/performance#106 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

targos mentioned this pull request Nov 12, 2023
v20.10.0 release proposal #50682
Merged

juanarbol mentioned this pull request Dec 6, 2023
2023-12-06, N|Solid v5.0.1 Iron Release nodesource/nsolid#41
Merged

Uh oh!

Uh oh!

Conversation

CanadaHonk commented Sep 25, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CanadaHonk commented Sep 25, 2023

Uh oh!

nodejs-github-bot commented Sep 25, 2023

Uh oh!

nodejs-github-bot commented Sep 25, 2023

Uh oh!

CanadaHonk commented Sep 25, 2023

Uh oh!

nodejs-github-bot commented Sep 25, 2023

Uh oh!

CanadaHonk commented Sep 26, 2023

Uh oh!

CanadaHonk commented Sep 26, 2023

Uh oh!

nodejs-github-bot commented Sep 26, 2023

Uh oh!

nodejs-github-bot commented Sep 26, 2023

Uh oh!

anonrig commented Sep 27, 2023

Uh oh!

joyeecheung commented Oct 2, 2023

Uh oh!

nodejs-github-bot commented Oct 11, 2023

Uh oh!

nodejs-github-bot commented Oct 11, 2023

Uh oh!

Uh oh!

nodejs-github-bot commented Oct 17, 2023

Uh oh!

nodejs-github-bot commented Oct 19, 2023

Uh oh!

nodejs-github-bot commented Oct 20, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants