Skip to content

fs: improve error performance for unlinkSync - #49856

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
CanadaHonk:perf-unlinksync
Sep 27, 2023
Merged

fs: improve error performance for unlinkSync#49856
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
CanadaHonk:perf-unlinksync

Conversation

@CanadaHonk

@CanadaHonkCanadaHonk commented Sep 25, 2023•
edited by anonrig
Loading

Copy link
Copy Markdown
Member

Results from i7 Windows laptop:

 confidence improvement accuracy (*) (**) (***)
fs\bench-unlinkSync.js n=1000 type='existing' 1.47 % ±6.49% ±8.64% ±11.25%
fs\bench-unlinkSync.js n=1000 type='non-existing' *** 75.14 % ±15.72% ±21.01% ±27.54%

Ref: nodejs/performance#106

Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1414/

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Sep 25, 2023
@anonriganonrig mentioned this pull request Sep 25, 2023
Open
@anonriganonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 25, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54216/

@anonriganonrig added commit-queue Add this label to land a pull request using GitHub Actions. needs-benchmark-ci PR that need a benchmark CI run. labels Sep 25, 2023
@anonrig

anonrig commented Sep 25, 2023•
edited by targos
Loading

Copy link
Copy Markdown
Member

Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1414/

17:17:09 confidence improvement accuracy (*) (**) (***)
17:17:09 fs/bench-unlinkSync.js n=1000 type='existing' 2.75 % ±4.00% ±5.34% ±7.01%
17:17:09 fs/bench-unlinkSync.js n=1000 type='non-existing' *** 100.74 % ±7.23% ±9.70% ±12.79%

@anonriganonrig added the performance Issues and PRs related to the performance of Node.js. label Sep 25, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 25, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54228/

@github-actionsgithub-actionsBot mentioned this pull request Sep 27, 2023
Open
21 tasks
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 27, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 7e0b6a5 into nodejs:mainSep 27, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 27, 2023

Copy link
Copy Markdown
Collaborator

Landed in 7e0b6a5

@github-actionsgithub-actionsBot mentioned this pull request Sep 28, 2023
Open
19 tasks
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
@CanadaHonk@ruyadorno
fs: improve error performance for unlinkSync
e82e46c
PR-URL: #49856
Refs: nodejs/performance#106
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@ruyadornoruyadorno mentioned this pull request Sep 28, 2023
Closed
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
@CanadaHonk@ruyadorno
fs: improve error performance for unlinkSync
6acf800
PR-URL: #49856
Refs: nodejs/performance#106
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@ruyadornoruyadorno mentioned this pull request Sep 28, 2023
Merged
debadree25 pushed a commit to debadree25/node that referenced this pull request Apr 15, 2024
@CanadaHonk@debadree25
fs: improve error performance for unlinkSync
8bc06eb
PR-URL: nodejs#49856
Refs: nodejs/performance#106
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamingrbenjamingrbenjamingr approved these changes
@anonriganonriganonrig approved these changes

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.fsIssues and PRs related to the fs subsystem / file system.needs-benchmark-ciPR that need a benchmark CI run.needs-ciPRs that need a full CI run.performanceIssues and PRs related to the performance of Node.js.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@CanadaHonk@nodejs-github-bot@anonrig@benjamingr