deps: V8: cherry-pick 8ec2651fbdd8 by abmusse · Pull Request #49862 · nodejs/node

abmusse · 2023-09-25T16:46:07Z

Original commit message:

fix: EmbeddedTargetOs on IBM i with Python 3.9
For some context, Python 3.9 on IBM i returns "os400" for sys.platform
instead of "aix". We used to build with Python 3.6 which returned "aix"
as the platform
When attempting to build Node.js with python 3.9 on IBM i we run into a
build error.
Ref: https://github.com/nodejs/node/pull/48056
Ref: https://github.com/nodejs/node/pull/48056#issuecomment-1553719508
I'm not quite sure where target_os is being passed down to the function ToEmbeddedTargetOs.
It seems as though target_os is being generated from sys.platform or
similar call from python as we started running into this issue after
building with Python 3.9.
This PR supersedes initial changes proposed in:
https://chromium-review.googlesource.com/c/v8/v8/+/4259330
This PR contains the minimal changes to successfully build Node.js (builds v8 as an internal dep)
on IBM i with Python 3.9.
Change-Id: I32d43197bce994a72a0d85091e91f80eeea4482d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4846413
Commit-Queue: Jakob Linke <jgruber@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Jakob Linke <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/main@{#89981}

Refs: v8/v8@8ec2651

CC @nodejs/platform-ibmi

Original commit message: fix: EmbeddedTargetOs on IBM i with Python 3.9 For some context, Python 3.9 on IBM i returns "os400" for sys.platform instead of "aix". We used to build with Python 3.6 which returned "aix" as the platform When attempting to build Node.js with python 3.9 on IBM i we run into a build error. Ref: #48056 Ref: #48056 (comment) I'm not quite sure where target_os is being passed down to the function ToEmbeddedTargetOs. It seems as though target_os is being generated from sys.platform or similar call from python as we started running into this issue after building with Python 3.9. This PR supersedes initial changes proposed in: https://chromium-review.googlesource.com/c/v8/v8/+/4259330 This PR contains the minimal changes to successfully build Node.js (builds v8 as an internal dep) on IBM i with Python 3.9. Change-Id: I32d43197bce994a72a0d85091e91f80eeea4482d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4846413 Commit-Queue: Jakob Linke <jgruber@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Jakob Linke <jgruber@chromium.org> Cr-Commit-Position: refs/heads/main@{#89981} Refs: v8/v8@8ec2651

nodejs-github-bot · 2023-09-25T16:46:11Z

Review requested:

@nodejs/v8-update

richardlau · 2023-09-25T16:51:27Z

hmm @abmusse did common.gypi get updated on your branch (bumping the v8_embedder_string? It's possible that its not showing as a change here in this PR because #49703 landed today, which also bumped that string.

abmusse · 2023-09-25T16:57:47Z

Hmm I'm not seeing common.gypi updated on my branch.

After backporting the v8 commit with:

git node v8 backport '8ec2651'

I did rebase the changes on main before pushing the commit up.

git pull --rebase origin main

richardlau · 2023-09-25T17:02:23Z

ah, the rebase would have realized that the common.gypi change was already done in an upstream commit to main (which makes the change in your commit a no-op so it's not included). Could you push a change to bump the number of v8_embedder_string by one?

abmusse · 2023-09-25T17:16:01Z

ah, the rebase would have realized that the common.gypi change was already done in an upstream commit to main (which makes the change in your commit a no-op so it's not included). Could you push a change to bump the number of v8_embedder_string by one?

Thanks for heads up! I bumped this up in 6a3bcee

nodejs-github-bot · 2023-09-25T17:30:49Z

CI: https://ci.nodejs.org/job/node-test-pull-request/54222/

nodejs-github-bot · 2023-09-25T17:31:25Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5584/

nodejs-github-bot · 2023-09-25T17:31:45Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5584/

nodejs-github-bot · 2023-09-25T17:37:01Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5584/

nodejs-github-bot · 2023-09-25T20:20:33Z

CI: https://ci.nodejs.org/job/node-test-pull-request/54235/

nodejs-github-bot · 2023-09-26T13:46:29Z

CI: https://ci.nodejs.org/job/node-test-pull-request/54248/

mhdawson

LGTM

nodejs-github-bot · 2023-09-27T19:26:04Z

Landed in 3838b57

Original commit message: fix: EmbeddedTargetOs on IBM i with Python 3.9 For some context, Python 3.9 on IBM i returns "os400" for sys.platform instead of "aix". We used to build with Python 3.6 which returned "aix" as the platform When attempting to build Node.js with python 3.9 on IBM i we run into a build error. Ref: #48056 Ref: #48056 (comment) I'm not quite sure where target_os is being passed down to the function ToEmbeddedTargetOs. It seems as though target_os is being generated from sys.platform or similar call from python as we started running into this issue after building with Python 3.9. This PR supersedes initial changes proposed in: https://chromium-review.googlesource.com/c/v8/v8/+/4259330 This PR contains the minimal changes to successfully build Node.js (builds v8 as an internal dep) on IBM i with Python 3.9. Change-Id: I32d43197bce994a72a0d85091e91f80eeea4482d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4846413 Commit-Queue: Jakob Linke <jgruber@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Jakob Linke <jgruber@chromium.org> Cr-Commit-Position: refs/heads/main@{#89981} Refs: v8/v8@8ec2651 PR-URL: #49862 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

Original commit message: fix: EmbeddedTargetOs on IBM i with Python 3.9 For some context, Python 3.9 on IBM i returns "os400" for sys.platform instead of "aix". We used to build with Python 3.6 which returned "aix" as the platform When attempting to build Node.js with python 3.9 on IBM i we run into a build error. Ref: nodejs#48056 Ref: nodejs#48056 (comment) I'm not quite sure where target_os is being passed down to the function ToEmbeddedTargetOs. It seems as though target_os is being generated from sys.platform or similar call from python as we started running into this issue after building with Python 3.9. This PR supersedes initial changes proposed in: https://chromium-review.googlesource.com/c/v8/v8/+/4259330 This PR contains the minimal changes to successfully build Node.js (builds v8 as an internal dep) on IBM i with Python 3.9. Change-Id: I32d43197bce994a72a0d85091e91f80eeea4482d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4846413 Commit-Queue: Jakob Linke <jgruber@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Jakob Linke <jgruber@chromium.org> Cr-Commit-Position: refs/heads/main@{#89981} Refs: v8/v8@8ec2651 PR-URL: nodejs#49862 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

nodejs-github-bot added needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Sep 25, 2023

abmusse mentioned this pull request Sep 25, 2023
build: fix IBM i build with Python 3.9 #48056
Closed

fixup! deps: V8: cherry-pick 8ec2651fbdd8
6a3bcee

richardlau approved these changes Sep 25, 2023
View reviewed changes

richardlau added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 25, 2023

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2023

github-actionsBot mentioned this pull request Sep 27, 2023
CI Reliability 2023-09-27 nodejs/reliability#676
Open
21 tasks

debadree25 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 27, 2023

mhdawson approved these changes Sep 27, 2023
View reviewed changes

richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 27, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 27, 2023

nodejs-github-bot merged commit 3838b57 into nodejs:mainSep 27, 2023

abmusse deleted the backport-v8-patch-ibmi-with-python39 branch September 27, 2023 19:33

github-actionsBot mentioned this pull request Sep 28, 2023
CI Reliability 2023-09-28 nodejs/reliability#677
Open
19 tasks

RafaelGSS mentioned this pull request Oct 9, 2023
2023-10-17, Version 21.0.0 (Current) #49870
Merged

targos mentioned this pull request Nov 12, 2023
v20.10.0 release proposal #50682
Merged

juanarbol mentioned this pull request Dec 6, 2023
2023-12-06, N|Solid v5.0.1 Iron Release nodesource/nsolid#41
Merged

Uh oh!

Uh oh!

Conversation

abmusse commented Sep 25, 2023

Uh oh!

nodejs-github-bot commented Sep 25, 2023

Uh oh!

richardlau commented Sep 25, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

abmusse commented Sep 25, 2023

Uh oh!

richardlau commented Sep 25, 2023

Uh oh!

abmusse commented Sep 25, 2023

Uh oh!

nodejs-github-bot commented Sep 25, 2023

Uh oh!

nodejs-github-bot commented Sep 25, 2023

Uh oh!

nodejs-github-bot commented Sep 25, 2023

Uh oh!

nodejs-github-bot commented Sep 25, 2023

Uh oh!

nodejs-github-bot commented Sep 25, 2023

Uh oh!

nodejs-github-bot commented Sep 26, 2023

Uh oh!

mhdawson left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Sep 27, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

richardlau commented Sep 25, 2023•
edited
Loading