Skip to content

fs: improve error performance for fs.renameSync - #49863

Closed
anonrig wants to merge 1 commit into
nodejs:mainfrom
anonrig:improve-fs-renamesync
Closed

fs: improve error performance for fs.renameSync#49863
anonrig wants to merge 1 commit into
nodejs:mainfrom
anonrig:improve-fs-renamesync

Conversation

@anonrig

Copy link
Copy Markdown
Member
 confidence improvement accuracy (*) (**) (***)
fs/bench-renameSync.js n=1000 type='invalid' *** 50.69 % ±16.74% ±22.31% ±29.10%
fs/bench-renameSync.js n=1000 type='valid' 1.87 % ±12.40% ±16.50% ±21.48%
Be aware that when doing many comparisons the risk of a false-positive result increases.
In this case, there are 2 comparisons, you can thus expect the following amount of false-positive results:
0.10 false positives, when considering a 5% risk acceptance (*, **, ***),
0.02 false positives, when considering a 1% risk acceptance (**, ***),
0.00 false positives, when considering a 0.1% risk acceptance (***)

Ref: nodejs/performance#106

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Sep 25, 2023
@anonrig

anonrig commented Sep 25, 2023

Copy link
Copy Markdown
MemberAuthor

Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1417/

22:15:50 confidence improvement accuracy (*) (**) (***)
22:15:50 fs/bench-renameSync.js n=1000 type='invalid' *** 64.92 % ±1.56% ±2.08% ±2.71%
22:15:50 fs/bench-renameSync.js n=1000 type='valid' 0.85 % ±4.16% ±5.56% ±7.29%

@anonriganonrig added performance Issues and PRs related to the performance of Node.js. needs-benchmark-ci PR that need a benchmark CI run. labels Sep 25, 2023
Comment threadsrc/node_file.cc Outdated
@anonrig
anonrig requested a review from targosSeptember 25, 2023 18:57
@anonrig
anonrigforce-pushed the improve-fs-renamesync branch from 4c1f660 to 1d48a89CompareSeptember 26, 2023 15:23
@anonriganonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 26, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 26, 2023
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@anonrig
anonrigforce-pushed the improve-fs-renamesync branch from 1d48a89 to 2b4baa4CompareSeptember 27, 2023 13:14
@anonriganonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 27, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 27, 2023
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@targos
targos removed their request for review September 28, 2023 13:50
@anonrig

Copy link
Copy Markdown
MemberAuthor

Closing in favor of #49962

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++Issues and PRs that require attention from people who are familiar with C++.lib / srcIssues and PRs related to general changes in the lib or src directory.needs-benchmark-ciPR that need a benchmark CI run.needs-ciPRs that need a full CI run.performanceIssues and PRs related to the performance of Node.js.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@anonrig@nodejs-github-bot@targos