meta: update website team with new name by Trott · Pull Request #49883 · nodejs/node

Trott · 2023-09-26T18:28:51Z

Pings for the website team aren't working because the team name changed but it did not get updated in CODEOWNERS.

nodejs-github-bot · 2023-09-26T18:28:55Z

Review requested:

@nodejs/tsc

Trott · 2023-09-26T18:29:04Z

@ovflowd

github-actions · 2023-09-26T18:29:25Z

Fast-track has been requested by @Trott. Please 👍 to approve.

ovflowd · 2023-09-26T19:17:19Z

@Trott can you update the PR? The correct team here would be @nodejs/web-infra

(Due to this being a more technical + infrastructure part (the API tooling))

Trott · 2023-09-26T19:19:40Z

@Trott can you update the PR? The correct team here would be @nodejs/web-infra
(Due to this being a more technical + infrastructure part (the API tooling))

Are you sure about that? I mean, maybe the tools line, but are you sure you want infra to be pinged for the template.html file or the asset files? I'm updating this because the ping on #49882 didn't happen and that seems more like a website issue than an infra issue. If you say I'm wrong, I'll make them all infra, but I would think it would be all website and maybe infra in addition on the tools one?

ovflowd · 2023-09-26T19:31:23Z

@Trott can you update the PR? The correct team here would be @nodejs/web-infra
(Due to this being a more technical + infrastructure part (the API tooling))
Are you sure about that? I mean, maybe the tools line, but are you sure you want infra to be pinged for the template.html file or the asset files? I'm updating this because the ping on #49882 didn't happen and that seems more like a website issue than an infra issue. If you say I'm wrong, I'll make them all infra, but I would think it would be all website and maybe infra in addition on the tools one?

That's fair. Let's keep for the template to the website and tooling to web-infra

nodejs-github-bot · 2023-09-28T21:18:41Z

Commit Queue failed

- Loading data for nodejs/node/pull/49883
✔ Done loading data for nodejs/node/pull/49883
----------------------------------- PR info ------------------------------------
Title meta: update website team with new name (#49883)
Author Rich Trott (@Trott)
Branch Trott:codeowners -> nodejs:main
Labels meta, fast-track, commit-queue-squash
Commits 5
- meta: update website team with new name
- Merge branch 'main' into codeowners
- Merge branch 'main' into codeowners
- Update .github/CODEOWNERS
- Merge branch 'main' into codeowners
Committers 2
- Rich Trott - GitHub PR-URL: https://github.com/nodejs/node/pull/49883
Reviewed-By: Yagiz Nizipli Reviewed-By: Antoine du Hamel Reviewed-By: Claudio Wunder Reviewed-By: Moshe Atlow Reviewed-By: Darshan Sen Reviewed-By: Tobias Nießen Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/49883
Reviewed-By: Yagiz Nizipli Reviewed-By: Antoine du Hamel Reviewed-By: Claudio Wunder Reviewed-By: Moshe Atlow Reviewed-By: Darshan Sen Reviewed-By: Tobias Nießen Reviewed-By: Luigi Pinca --------------------------------------------------------------------------------
⚠ Commits were pushed since the last approving review:
⚠ - Update .github/CODEOWNERS
⚠ - Merge branch 'main' into codeowners
ℹ This PR was created on Tue, 26 Sep 2023 18:28:51 GMT
✔ Approvals: 7
✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/49883#pullrequestreview-1644961950
✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/49883#pullrequestreview-1645005247
✔ - Claudio Wunder (@ovflowd): https://github.com/nodejs/node/pull/49883#pullrequestreview-1645020927
✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/49883#pullrequestreview-1645030663
✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/49883#pullrequestreview-1645620447
✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/49883#pullrequestreview-1647064713
✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/49883#pullrequestreview-1647488560
ℹ This PR is being fast-tracked
✔ Last GitHub CI successful
ℹ Green GitHub CI is sufficient
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/6344268112

Pings for the website team aren't working because the team name changed but it did not get updated in CODEOWNERS. PR-URL: nodejs#49883 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Claudio Wunder <cwunder@gnome.org> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Trott · 2023-09-28T21:24:05Z

Landed in 0fe673c

Pings for the website team aren't working because the team name changed but it did not get updated in CODEOWNERS. PR-URL: #49883 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Claudio Wunder <cwunder@gnome.org> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Pings for the website team aren't working because the team name changed but it did not get updated in CODEOWNERS. PR-URL: nodejs#49883 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Claudio Wunder <cwunder@gnome.org> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Pings for the website team aren't working because the team name changed but it did not get updated in CODEOWNERS. PR-URL: nodejs/node#49883 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Claudio Wunder <cwunder@gnome.org> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Sep 26, 2023

Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Sep 26, 2023

Trott requested a review from ovflowd September 26, 2023 18:29

anonrig approved these changes Sep 26, 2023
View reviewed changes

aduh95 approved these changes Sep 26, 2023
View reviewed changes

ovflowd approved these changes Sep 26, 2023
View reviewed changes

MoLow approved these changes Sep 26, 2023
View reviewed changes

RaisinTen approved these changes Sep 27, 2023
View reviewed changes

tniessen approved these changes Sep 27, 2023
View reviewed changes

ovflowd reviewed Sep 27, 2023
View reviewed changes

Comment thread.github/CODEOWNERS Outdated

lpinca approved these changes Sep 27, 2023
View reviewed changes

Trott added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 28, 2023

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 28, 2023

Trott force-pushed the codeowners branch from e6c1972 to 55518beCompare September 28, 2023 21:22

Trott force-pushed the codeowners branch from 55518be to 0fe673cCompare September 28, 2023 21:23

Trott merged commit 0fe673c into nodejs:mainSep 28, 2023

Trott deleted the codeowners branch September 28, 2023 21:24

RafaelGSS mentioned this pull request Oct 9, 2023
2023-10-17, Version 21.0.0 (Current) #49870
Merged

targos mentioned this pull request Nov 12, 2023
v20.10.0 release proposal #50682
Merged

targos mentioned this pull request Nov 28, 2023
v18.19.0 release proposal #50953
Merged

juanarbol mentioned this pull request Dec 6, 2023
2023-12-06, N|Solid v5.0.1 Iron Release nodesource/nsolid#41
Merged

Navigation Menu

Uh oh!

Uh oh!

meta: update website team with new name - #49883

meta: update website team with new name#49883
Trott merged 1 commit into
nodejs:mainfrom
Trott:codeowners

Trott commented Sep 26, 2023

Uh oh!

nodejs-github-bot commented Sep 26, 2023

Uh oh!

Trott commented Sep 26, 2023

Uh oh!

github-actionsBot commented Sep 26, 2023

Uh oh!

ovflowd commented Sep 26, 2023•
edited
Loading

Uh oh!

Trott commented Sep 26, 2023•
edited
Loading

Uh oh!

ovflowd commented Sep 26, 2023

Uh oh!

Uh oh!

nodejs-github-bot commented Sep 28, 2023

Uh oh!

Trott commented Sep 28, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Uh oh!

Uh oh!

Conversation

Trott commented Sep 26, 2023

Uh oh!

nodejs-github-bot commented Sep 26, 2023

Uh oh!

Trott commented Sep 26, 2023

Uh oh!

github-actionsBot commented Sep 26, 2023

Uh oh!

ovflowd commented Sep 26, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Trott commented Sep 26, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ovflowd commented Sep 26, 2023

Uh oh!

Uh oh!

nodejs-github-bot commented Sep 28, 2023

Uh oh!

Trott commented Sep 28, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

ovflowd commented Sep 26, 2023•
edited
Loading

Trott commented Sep 26, 2023•
edited
Loading