Uh oh!
There was an error while loading. Please reload this page.
[v20.x backport] test_runner: catch reporter errors - #49941
Closed
MoLow wants to merge 1 commit into
Closed
Conversation
PR-URL: nodejs#49646Fixes: nodejs#48937 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
nodejs-github-bot
commented
Sep 28, 2023
Collaborator
Review requested:
|
rluvaton
approved these changes
Nov 1, 2023
MoLow
commented
Nov 8, 2023
MemberAuthor
@nodejs/releasers can this land? |
RafaelGSS
commented
Nov 10, 2023
Member
We will land it when creating the release proposal and technically this PR needs Jenkins CI. |
nodejs-github-bot
commented
Nov 12, 2023
Collaborator
targos
commented
Nov 12, 2023
Member
Commit landed cleanly after other ones and is part of #50682 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backporting #49646