wasi: fix up wasi tests for ibmi by mhdawson · Pull Request #49953 · nodejs/node

mhdawson · 2023-09-29T14:24:53Z

ibmi now reports os400 instead of aix

nodejs-github-bot · 2023-09-29T14:24:57Z

Review requested:

@nodejs/wasi

mhdawson · 2023-09-29T14:25:47Z

@richardlau as discussed.

nodejs-github-bot · 2023-09-29T19:16:27Z

CI: https://ci.nodejs.org/job/node-test-pull-request/54387/

nodejs-github-bot · 2023-10-02T22:41:36Z

CI: https://ci.nodejs.org/job/node-test-pull-request/54478/

mhdawson · 2023-10-03T13:47:47Z

@richardlau will take another look to figure out what is going on.

mhdawson · 2023-10-03T21:34:21Z

Turns out the problem is that a newer version of the wasi-sdk has changed behaviour. I used the latest which was version 20. The docs dont' say what version was used before. I'll update the PR to fix up to work with wasi-sdk version 20 and to document that is the version which should be used.

mhdawson · 2023-10-03T21:45:24Z

Ok PR updated, I had to make other changes as well due to other behaviour changes in wask-sdk verison 20, so we'll see if the CI is happy across platforms.

ibmi now reports os400 instead of aix - update platform check in poll to allow for os400 - update wasi-sdk level to 20 - document the level of wasi-sdk used to compile the tests - remove platform check in readdir test as it does not seem to be needed with wasi-sdk version 20 - comment out tests for some clocks which are no longer available when compiling with wasi-sdk level 20. These may be added back after WebAssembly/wasi-libc#266 is resolved. Signed-off-by: Michael Dawson <midawson@redhat.com>

nodejs-github-bot · 2023-10-03T22:07:11Z

CI: https://ci.nodejs.org/job/node-test-pull-request/54508/

nodejs-github-bot · 2023-10-03T23:53:41Z

CI: https://ci.nodejs.org/job/node-test-pull-request/54517/

richardlau · 2023-10-04T12:50:40Z

Ok PR updated, I had to make other changes as well due to other behaviour changes in wask-sdk verison 20, so we'll see if the CI is happy across platforms.

This looks good sans the linter failure.
FWIW IBM i CI on d7650a3 shows test-wasi now passing 🎉: https://ci.nodejs.org/job/node-test-commit-ibmi/1314/

Signed-off-by: Michael Dawson <midawson@redhat.com>

mhdawson · 2023-10-04T13:13:15Z

Pushed commit to fix linter complaint.

nodejs-github-bot · 2023-10-04T13:29:30Z

CI: https://ci.nodejs.org/job/node-test-pull-request/54526/

mhdawson · 2023-10-04T14:52:34Z

osx failure looks like a flaky test - created this issue to track it - #50040

nodejs-github-bot · 2023-10-04T16:35:41Z

Landed in 9cb8eb7

ibmi now reports os400 instead of aix - update platform check in poll to allow for os400 - update wasi-sdk level to 20 - document the level of wasi-sdk used to compile the tests - remove platform check in readdir test as it does not seem to be needed with wasi-sdk version 20 - comment out tests for some clocks which are no longer available when compiling with wasi-sdk level 20. These may be added back after WebAssembly/wasi-libc#266 is resolved. Signed-off-by: Michael Dawson <midawson@redhat.com> PR-URL: #49953 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

ibmi now reports os400 instead of aix - update platform check in poll to allow for os400 - update wasi-sdk level to 20 - document the level of wasi-sdk used to compile the tests - remove platform check in readdir test as it does not seem to be needed with wasi-sdk version 20 - comment out tests for some clocks which are no longer available when compiling with wasi-sdk level 20. These may be added back after WebAssembly/wasi-libc#266 is resolved. Signed-off-by: Michael Dawson <midawson@redhat.com> PR-URL: nodejs#49953 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 29, 2023

richardlau approved these changes Sep 29, 2023
View reviewed changes

richardlau mentioned this pull request Sep 29, 2023
build: fix IBM i build with Python 3.9 #48056
Closed

anonrig approved these changes Sep 29, 2023
View reviewed changes

richardlau added the ibm i Issues and PRs related to the IBM i platform. label Sep 29, 2023

lpinca approved these changes Sep 29, 2023
View reviewed changes

richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 29, 2023

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 29, 2023

richardlau reviewed Sep 29, 2023
View reviewed changes

Comment threadtest/wasi/c/readdir.c Outdated

This was referenced Sep 30, 2023
CI Reliability 2023-09-30 nodejs/reliability#679
Open
CI Reliability 2023-10-01 nodejs/reliability#680
Open
CI Reliability 2023-10-02 nodejs/reliability#681
Open

richardlau added request-ci Add this label to start a Jenkins CI on a PR. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Oct 2, 2023

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 2, 2023

github-actionsBot mentioned this pull request Oct 3, 2023
CI Reliability 2023-10-03 nodejs/reliability#682
Open
18 tasks

mhdawson force-pushed the fixuvwasi-ibmi branch from e66205b to 44a5528Compare October 3, 2023 21:44

mhdawson force-pushed the fixuvwasi-ibmi branch from 44a5528 to 7873db3Compare October 3, 2023 22:01

mhdawson added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 3, 2023

mhdawson force-pushed the fixuvwasi-ibmi branch from 7873db3 to d7650a3Compare October 3, 2023 22:04

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 3, 2023

github-actionsBot mentioned this pull request Oct 4, 2023
CI Reliability 2023-10-04 nodejs/reliability#683
Open
14 tasks

squash: fixup for linter
280a28b
Signed-off-by: Michael Dawson <midawson@redhat.com>

richardlau approved these changes Oct 4, 2023
View reviewed changes

richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 4, 2023

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 4, 2023

richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 4, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 4, 2023

nodejs-github-bot merged commit 9cb8eb7 into nodejs:mainOct 4, 2023

This was referenced Oct 5, 2023
CI Reliability 2023-10-05 nodejs/reliability#684
Open
CI Reliability 2023-10-06 nodejs/reliability#685
Open
CI Reliability 2023-10-07 nodejs/reliability#686
Open
CI Reliability 2023-10-08 nodejs/reliability#687
Open

RafaelGSS mentioned this pull request Oct 9, 2023
2023-10-17, Version 21.0.0 (Current) #49870
Merged

targos mentioned this pull request Nov 12, 2023
v20.10.0 release proposal #50682
Merged

juanarbol mentioned this pull request Dec 6, 2023
2023-12-06, N|Solid v5.0.1 Iron Release nodesource/nsolid#41
Merged

Uh oh!

Uh oh!

Conversation

mhdawson commented Sep 29, 2023

Uh oh!

nodejs-github-bot commented Sep 29, 2023

Uh oh!

mhdawson commented Sep 29, 2023

Uh oh!

nodejs-github-bot commented Sep 29, 2023

Uh oh!

Uh oh!

nodejs-github-bot commented Oct 2, 2023

Uh oh!

mhdawson commented Oct 3, 2023

Uh oh!

mhdawson commented Oct 3, 2023

Uh oh!

mhdawson commented Oct 3, 2023

Uh oh!

nodejs-github-bot commented Oct 3, 2023

Uh oh!

nodejs-github-bot commented Oct 3, 2023

Uh oh!

richardlau commented Oct 4, 2023

Uh oh!

mhdawson commented Oct 4, 2023

Uh oh!

nodejs-github-bot commented Oct 4, 2023

Uh oh!

mhdawson commented Oct 4, 2023

Uh oh!

nodejs-github-bot commented Oct 4, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants