Uh oh!
There was an error while loading. Please reload this page.
doc: fix inconsistent styling - #4996
Closed
mscdex wants to merge 1 commit into
Closed
Conversation
Member
There was a problem hiding this comment.
Nit, while you're in there: Remove personal pronoun.
Before:
You could provide an issuer via
caoption.
After, something like:
An issuer may be provided via the
caoption.
Trott
commented
Jan 31, 2016
Member
LGTM with a take-it-or-leave-it nit. |
targos
commented
Jan 31, 2016
Member
LGTM |
jasnell
commented
Feb 1, 2016
Member
LGTM with nit addressed |
mscdexforce-pushed
the
doc-tls-fix-styling
branch
from
February 4, 2016 02:30
3bcc34f to
cad34b3Comparemscdex
commented
Feb 4, 2016
ContributorAuthor
Wording changed as suggested. |
cjihrig
commented
Feb 4, 2016
Contributor
LGTM |
jasnell pushed a commit
that referenced
this pull request
Feb 4, 2016
PR-URL: #4996 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell
commented
Feb 4, 2016
Member
Landed in 01dd8ed |
rvagg pushed a commit
that referenced
this pull request
Feb 8, 2016
PR-URL: #4996 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
commented
Feb 18, 2016
Contributor
The changes in this are fairly minor, not landing cleanly, and bringing over other changes. I'm changing to dont-land for now. Please feel free to manually backport or get the conversation going again |
scovetta pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
PR-URL: nodejs#4996 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.