Skip to content

streams: use private symbol for bitmap state - #49993

Merged
Trott merged 1 commit into
nodejs:mainfrom
nxtedition:stream-private
Oct 14, 2023
Merged

streams: use private symbol for bitmap state#49993
Trott merged 1 commit into
nodejs:mainfrom
nxtedition:stream-private

Conversation

@ronag

@ronagronag commented Oct 1, 2023

Copy link
Copy Markdown
Member

No description provided.

@ronagronag added the stream Issues and PRs related to the stream subsystem. label Oct 1, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 1, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/streams

@nodejs-github-botnodejs-github-bot added the needs-ci PRs that need a full CI run. label Oct 1, 2023
benjamingr
benjamingr approved these changes Oct 1, 2023
View reviewed changes

@benjamingrbenjamingr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with benchmark

@ronag

ronag commented Oct 1, 2023

Copy link
Copy Markdown
MemberAuthor

https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1431/

mcollina
mcollina approved these changes Oct 1, 2023
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@benjamingrbenjamingr added the needs-benchmark-ci PR that need a benchmark CI run. label Oct 1, 2023
@ronagronag added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 9, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 9, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@ronagronag added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 9, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 9, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
mcollina
mcollina approved these changes Oct 9, 2023
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Uzlopak
Uzlopak approved these changes Oct 9, 2023
View reviewed changes

@UzlopakUzlopak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@github-actionsgithub-actionsBot mentioned this pull request Oct 10, 2023
Open
24 tasks
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@github-actionsgithub-actionsBot mentioned this pull request Oct 11, 2023
Open
30 tasks
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@rluvatonrluvaton added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 14, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 14, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Oct 14, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54781/

@Trott

Trott commented Oct 14, 2023

Copy link
Copy Markdown
Member

The AIX CI passed, but the widget says it failed. 🤷 I'll land this manually.

@Trott
Trott merged commit aad8002 into nodejs:mainOct 14, 2023
@Trott

Trott commented Oct 14, 2023

Copy link
Copy Markdown
Member

Landed in aad8002

@RafaelGSSRafaelGSS mentioned this pull request Oct 15, 2023
Merged
targos pushed a commit that referenced this pull request Nov 11, 2023
@ronag@targos
stream: use private symbol for bitmap state
e60b3ab
PR-URL: #49993
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
@targostargos mentioned this pull request Nov 12, 2023
Merged
@juanarboljuanarbol mentioned this pull request Dec 6, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@benjamingrbenjamingrbenjamingr approved these changes
@anonriganonriganonrig approved these changes
@rluvatonrluvatonrluvaton approved these changes
+1 more reviewer
@UzlopakUzlopakUzlopak approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-benchmark-ciPR that need a benchmark CI run.needs-ciPRs that need a full CI run.streamIssues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@ronag@nodejs-github-bot@Trott@mcollina@benjamingr@anonrig@Uzlopak@rluvaton