Skip to content

fs: improve error performance of readvSync - #50100

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
IlyasShabi:readv-sync
Dec 5, 2023
Merged

fs: improve error performance of readvSync#50100
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
IlyasShabi:readv-sync

Conversation

@IlyasShabi

@IlyasShabiIlyasShabi commented Oct 9, 2023

Copy link
Copy Markdown
Member

Local benchmark:

 confidence improvement accuracy (*) (**) (***)
fs/bench-readvSync.js n=100000 type='invalid' *** 123.02 % ±1.27% ±1.70% ±2.24%
fs/bench-readvSync.js n=100000 type='valid' 2.74 % ±2.88% ±3.84% ±5.01%

Ref: nodejs/performance#106

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Oct 9, 2023
anonrig
anonrig reviewed Oct 9, 2023
View reviewed changes
Comment threadsrc/node_file.cc Outdated
@anonriganonrig added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Oct 10, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 10, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 10, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54643/

@anonriganonrig mentioned this pull request Oct 10, 2023
Open
@github-actionsgithub-actionsBot mentioned this pull request Oct 11, 2023
Open
30 tasks
@anonrig

anonrig commented Oct 13, 2023

Copy link
Copy Markdown
Member

Can you rebase and force push?

@anonriganonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 20, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 20, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 20, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55073/

This was referenced Oct 22, 2023
Open
Open
@nodejs-github-bot

nodejs-github-bot commented Oct 23, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55155/

This was referenced Oct 24, 2023
Open
Open
@aduh95aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 29, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 29, 2023
@nodejs-github-bot

nodejs-github-bot commented Nov 29, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56001/

@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 5, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 5, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 27b2ce5 into nodejs:mainDec 5, 2023
@nodejs-github-bot

nodejs-github-bot commented Dec 5, 2023

Copy link
Copy Markdown
Collaborator

Landed in 27b2ce5

RafaelGSS pushed a commit that referenced this pull request Dec 15, 2023
@IlyasShabi@RafaelGSS
fs: improve error performance of readvSync
3f7f3ce
PR-URL: #50100
Refs: nodejs/performance#106
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request Dec 15, 2023
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@IlyasShabi@richardlau
fs: improve error performance of readvSync
6764f0c
PR-URL: #50100
Refs: nodejs/performance#106
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@richardlaurichardlau mentioned this pull request Mar 25, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonriganonriganonrig approved these changes
@aduh95aduh95aduh95 approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.fsIssues and PRs related to the fs subsystem / file system.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@IlyasShabi@nodejs-github-bot@anonrig@aduh95@ilyasShabiCS