Skip to content

stream: reduce overhead of transfer - #50107

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
H4ad:perf/webstreams_writable
Oct 12, 2023
Merged

stream: reduce overhead of transfer#50107
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
H4ad:perf/webstreams_writable

Conversation

@H4ad

@H4adH4ad commented Oct 9, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Continuing the work started on nodejs/performance#109

 confidence improvement accuracy (*) (**) (***)
webstreams/js_transfer.js n=10000 payload='ReadableStream' *** 19.68 % ±1.77% ±2.35% ±3.06%
webstreams/js_transfer.js n=10000 payload='TransformStream' *** 18.80 % ±1.76% ±2.35% ±3.06%
webstreams/js_transfer.js n=10000 payload='WritableStream' *** 13.36 % ±1.73% ±2.30% ±3.00%
Be aware that when doing many comparisons the risk of a false-positive
result increases. In this case, there are 3 comparisons, you can thus
expect the following amount of false-positive results:
0.15 false positives, when considering a 5% risk acceptance (*, **, ***),
0.03 false positives, when considering a 1% risk acceptance (**, ***),
0.00 false positives, when considering a 0.1% risk acceptance (***)

/cc @nodejs/performance

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Oct 9, 2023
@H4ad
H4adforce-pushed the perf/webstreams_writable branch from bc826eb to b0b5614CompareOctober 10, 2023 12:15
@H4ad
H4ad marked this pull request as ready for review October 10, 2023 12:16
@H4ad
H4adforce-pushed the perf/webstreams_writable branch from 578d490 to d2e73bcCompareOctober 10, 2023 12:20
@H4ad
H4adforce-pushed the perf/webstreams_writable branch from d2e73bc to 68b0d91CompareOctober 10, 2023 12:22
@anonriganonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 10, 2023
mcollina
mcollina approved these changes Oct 10, 2023
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

H4ad
H4ad commented Oct 10, 2023
View reviewed changes
Comment threadlib/internal/webstreams/readablestream.js
Comment on lines +654 to +657
writable: undefined,
port1: undefined,
port2: undefined,
promise: undefined,

@H4adH4adOct 10, 2023

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For these properties, I followed what I saw in the constructor, the old version was wrong, right?

@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 10, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 10, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54652/

@anonriganonrig changed the title perf: webstreams transferstream: reduce overhead of transferOct 10, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 10, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54678/

@github-actionsgithub-actionsBot mentioned this pull request Oct 11, 2023
Open
30 tasks
mcollina
mcollina approved these changes Oct 11, 2023
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@H4ad

H4ad commented Oct 12, 2023

Copy link
Copy Markdown
MemberAuthor

Someone can add author ready?

@anonriganonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 12, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 12, 2023
@nodejs-github-bot
nodejs-github-bot merged commit a85e418 into nodejs:mainOct 12, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 12, 2023

Copy link
Copy Markdown
Collaborator

Landed in a85e418

@H4ad
H4ad deleted the perf/webstreams_writable branch October 12, 2023 14:42
@RafaelGSSRafaelGSS mentioned this pull request Oct 15, 2023
Merged
@MattiasBuelensMattiasBuelens mentioned this pull request May 1, 2024
Merged
@MattiasBuelensMattiasBuelens mentioned this pull request May 1, 2024
Closed
@targostargos mentioned this pull request Sep 19, 2024
Closed
@avivkelleravivkeller mentioned this pull request Sep 21, 2024
Closed
@jazellyjazelly mentioned this pull request Sep 22, 2024
Merged
nodejs-github-bot pushed a commit that referenced this pull request Sep 24, 2024
@jazelly
stream: set stream prototype to closest transferable superclass
0e52836
PR-URL: #55067Fixes: #54603
Refs: #50107
Reviewed-By: Mattias Buelens <mattias@buelens.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos pushed a commit that referenced this pull request Oct 4, 2024
@jazelly@targos
stream: set stream prototype to closest transferable superclass
bf69ae1
PR-URL: #55067Fixes: #54603
Refs: #50107
Reviewed-By: Mattias Buelens <mattias@buelens.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@QardQardQard approved these changes
@anonriganonriganonrig approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.lib / srcIssues and PRs related to general changes in the lib or src directory.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@H4ad@nodejs-github-bot@mcollina@Qard@anonrig@targos