Uh oh!
There was an error while loading. Please reload this page.
test: add EOVERFLOW as an allowed error - #50128
Merged
nodejs-github-bot merged 1 commit intoOct 12, 2023
Merged
Conversation
lpinca
approved these changes
Oct 10, 2023
richardlau
approved these changes
Oct 10, 2023
nodejs-github-bot
commented
Oct 10, 2023
Collaborator
anonrig
approved these changes
Oct 10, 2023
30 tasks
nodejs-github-bot
commented
Oct 11, 2023
Collaborator
nodejs-github-bot
commented
Oct 11, 2023
Collaborator
richardlau
commented
Oct 11, 2023
Member
https://ci.nodejs.org/job/node-test-commit-ibmi/1325/ shows the test now passes with this PR. The test-runner-cli-concurrency failure there will be addressed by #50108. |
nodejs-github-bot
commented
Oct 12, 2023
Collaborator
Landed in f0e720a |
abmusse
deleted the
fix-parallel-test-fs-read-promises-position-validation
branch
October 12, 2023 19:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in test-fs-read-promises-position-validation.mjs
As stated in #50054
This looks like an oversight as
test-fs-read-position-validation.mjs includes
EOVERFLOW as an allowed error.
Fixes#50054
CC @nodejs/platform-ibmi