Skip to content

doc: add information about Node-API versions >=9 - #50168

Closed
mhdawson wants to merge 15 commits into
nodejs:mainfrom
mhdawson:update-node-api-doc
Closed

doc: add information about Node-API versions >=9#50168
mhdawson wants to merge 15 commits into
nodejs:mainfrom
mhdawson:update-node-api-doc

Conversation

@mhdawson

@mhdawsonmhdawson commented Oct 12, 2023

Copy link
Copy Markdown
Member

No description provided.

@mhdawson
doc: add information about Node-API versions >=9
f84e39b
Signed-off-by: Michael Dawson <midawson@redhat.com>
@nodejs-github-bot

nodejs-github-bot commented Oct 12, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/node-api

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API. labels Oct 12, 2023
@mhdawson

mhdawson commented Oct 12, 2023

Copy link
Copy Markdown
MemberAuthor

@legendecas can you review to confirm I've gotten this correct.

vmoroz
vmoroz reviewed Oct 12, 2023
View reviewed changes
Comment threaddoc/api/n-api.md Outdated
vmoroz
vmoroz reviewed Oct 12, 2023
View reviewed changes
Comment threaddoc/api/n-api.md Outdated
vmoroz
vmoroz reviewed Oct 12, 2023
View reviewed changes
Comment threaddoc/api/n-api.md Outdated
mhdawsonand others added 2 commits October 13, 2023 15:48
@mhdawson
Update n-api.md
87155ef
@mhdawson
squash: make linter happy
aaad700
Signed-off-by: Michael Dawson <midawson@redhat.com>
Mifrill
Mifrill reviewed Oct 17, 2023
View reviewed changes
Comment threaddoc/api/n-api.md Outdated
mhdawsonand others added 2 commits October 17, 2023 14:00
@mhdawson@Mifrill
Update doc/api/n-api.md
626e1a2
Co-authored-by: Alex Strizhak <alexei.mifrill.strizhak@gmail.com>
@mhdawson
Update n-api.md
fd3279c
gabrielschulhof
gabrielschulhof reviewed Oct 18, 2023
View reviewed changes
Comment threaddoc/api/n-api.md Outdated
Comment threaddoc/api/n-api.md Outdated
Comment threaddoc/api/n-api.md Outdated
Comment threaddoc/api/n-api.md Outdated
Comment threaddoc/api/n-api.md Outdated
Comment threaddoc/api/n-api.md Outdated
Comment threaddoc/api/n-api.md Outdated
Comment threaddoc/api/n-api.md Outdated
mhdawsonand others added 8 commits October 20, 2023 09:34
@mhdawson@gabrielschulhof
Update doc/api/n-api.md
cfcc153
Co-authored-by: Gabriel Schulhof <gabrielschulhof@gmail.com>
@mhdawson@gabrielschulhof
Update doc/api/n-api.md
91db079
Co-authored-by: Gabriel Schulhof <gabrielschulhof@gmail.com>
@mhdawson@gabrielschulhof
Update doc/api/n-api.md
59552c9
Co-authored-by: Gabriel Schulhof <gabrielschulhof@gmail.com>
@mhdawson@gabrielschulhof
Update doc/api/n-api.md
bcaaf77
Co-authored-by: Gabriel Schulhof <gabrielschulhof@gmail.com>
@mhdawson@gabrielschulhof
Update doc/api/n-api.md
ef41a2f
Co-authored-by: Gabriel Schulhof <gabrielschulhof@gmail.com>
@mhdawson@gabrielschulhof
Update doc/api/n-api.md
ec30e4f
Co-authored-by: Gabriel Schulhof <gabrielschulhof@gmail.com>
@mhdawson@gabrielschulhof
Update doc/api/n-api.md
ef5fc04
Co-authored-by: Gabriel Schulhof <gabrielschulhof@gmail.com>
@mhdawson@gabrielschulhof
Update doc/api/n-api.md
0231b66
Co-authored-by: Gabriel Schulhof <gabrielschulhof@gmail.com>
@mhdawson

mhdawson commented Oct 20, 2023

Copy link
Copy Markdown
MemberAuthor

@gabrielschulhof thanks for the suggestions, pulled them all in.

@mhdawson

mhdawson commented Oct 23, 2023

Copy link
Copy Markdown
MemberAuthor

@gabrielschulhof@vmoroz believe it is ready for rev-review.

legendecas
legendecas approved these changes Oct 25, 2023
View reviewed changes

@legendecaslegendecas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM

mhdawson added a commit that referenced this pull request Oct 25, 2023
@mhdawson
doc: add information about Node-API versions >=9
7d30667
Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: #50168
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@mhdawson

mhdawson commented Oct 25, 2023

Copy link
Copy Markdown
MemberAuthor

Landed in 7d30667

targos pushed a commit that referenced this pull request Nov 11, 2023
@mhdawson@targos
doc: add information about Node-API versions >=9
d62e812
Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: #50168
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@targostargos mentioned this pull request Nov 12, 2023
Merged
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@mhdawson@UlisesGascon
doc: add information about Node-API versions >=9
cca55b8
Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: #50168
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@UlisesGasconUlisesGascon mentioned this pull request Dec 12, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vmorozvmorozvmoroz left review comments
@gabrielschulhofgabrielschulhofgabrielschulhof left review comments
@legendecaslegendecaslegendecas approved these changes
+1 more reviewer
@MifrillMifrillMifrill left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docIssues and PRs related to the documentations.node-apiIssues and PRs related to the Node-API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mhdawson@nodejs-github-bot@vmoroz@gabrielschulhof@legendecas@Mifrill