Uh oh!
There was an error while loading. Please reload this page.
util: remove internal mime fns from benchmarks - #50201
Merged
nodejs-github-bot merged 1 commit intoOct 21, 2023
Merged
Conversation
Uzlopak
commented
Oct 16, 2023
ContributorAuthor
anonrig
approved these changes
Oct 16, 2023
nodejs-github-bot
commented
Oct 16, 2023
Collaborator
RafaelGSS
approved these changes
Oct 17, 2023
RafaelGSS
left a comment
Member
There was a problem hiding this comment.
Sometimes we'll need to bench internal functions, but that's not the case. LGTM.
H4ad
approved these changes
Oct 17, 2023
Uzlopak
commented
Oct 17, 2023
ContributorAuthor
@RafaelGSS |
nodejs-github-bot
commented
Oct 17, 2023
Collaborator
nodejs-github-bot
commented
Oct 18, 2023
Collaborator
25 tasks
Uzlopak
commented
Oct 21, 2023
ContributorAuthor
@anonrig can this please be merged? |
nodejs-github-bot
commented
Oct 21, 2023
Collaborator
Landed in 2e5ffe9 |
targos pushed a commit
that referenced
this pull request
Oct 23, 2023
PR-URL: #50201 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
targos pushed a commit
that referenced
this pull request
Nov 11, 2023
PR-URL: #50201 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in @nodejs/performance meeting, benchmarks should be only benching user facing api.