Skip to content

stream: avoid getter for defaultEncoding - #50203

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
nxtedition:writable-default-encoding
Oct 23, 2023
Merged

stream: avoid getter for defaultEncoding#50203
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
nxtedition:writable-default-encoding

Conversation

@ronag

@ronagronag commented Oct 16, 2023

Copy link
Copy Markdown
Member

No description provided.

@nodejs-github-bot

nodejs-github-bot commented Oct 16, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/streams

@nodejs-github-botnodejs-github-bot added the needs-ci PRs that need a full CI run. label Oct 16, 2023
anonrig
anonrig reviewed Oct 16, 2023
View reviewed changes
Comment threadlib/internal/streams/writable.js Outdated
meyfa
meyfa reviewed Oct 16, 2023
View reviewed changes
Comment threadlib/internal/streams/writable.js Outdated
mcollina
mcollina approved these changes Oct 17, 2023
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ronagronag added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 17, 2023
@ronag
ronagforce-pushed the writable-default-encoding branch from afbc8dc to ada4899CompareOctober 17, 2023 17:46
@ronagronag added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 17, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 17, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 17, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54893/

@lpincalpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 17, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 17, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 17, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54901/

@nodejs-github-bot

nodejs-github-bot commented Oct 18, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54928/

@ronag
ronagforce-pushed the writable-default-encoding branch from 9493b26 to e05f661CompareOctober 18, 2023 09:27
pacifiquem
pacifiquem reviewed Oct 18, 2023
View reviewed changes

@pacifiquempacifiquem left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ronagronag added commit-queue Add this label to land a pull request using GitHub Actions. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 18, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 18, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 18, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54941/

@nodejs-github-botnodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 18, 2023
@github-actionsgithub-actionsBot mentioned this pull request Oct 20, 2023
Open
20 tasks
@ronagronag added request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Oct 21, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 21, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 21, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55093/

@nodejs-github-bot

nodejs-github-bot commented Oct 21, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55103/

@ronagronag added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 21, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 21, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 21, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/50203
✔ Done loading data for nodejs/node/pull/50203
----------------------------------- PR info ------------------------------------
Title stream: avoid getter for defaultEncoding (#50203)
Author Robert Nagy (@ronag)
Branch ronag:writable-default-encoding -> nodejs:main
Labels author ready, needs-ci
Commits 1
- stream: avoid getter for defaultEncoding
Committers 1
- Robert Nagy PR-URL: https://github.com/nodejs/node/pull/50203
Reviewed-By: Matteo Collina Reviewed-By: Benjamin Gruenbaum Reviewed-By: Yagiz Nizipli Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/50203
Reviewed-By: Matteo Collina Reviewed-By: Benjamin Gruenbaum Reviewed-By: Yagiz Nizipli Reviewed-By: Luigi Pinca --------------------------------------------------------------------------------
⚠ Commits were pushed since the last approving review:
⚠ - stream: avoid getter for defaultEncoding
ℹ This PR was created on Mon, 16 Oct 2023 18:49:29 GMT
✔ Approvals: 4
✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/50203#pullrequestreview-1681620676
✔ - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/50203#pullrequestreview-1682971946
✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/50203#pullrequestreview-1683007855
✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/50203#pullrequestreview-1683084786
✘ Last GitHub CI failed
ℹ Last Full PR CI on 2023-10-21T19:06:08Z: https://ci.nodejs.org/job/node-test-pull-request/55103/
- Querying data for job/node-test-pull-request/55103/
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/6599503281

@nodejs-github-botnodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Oct 21, 2023
This was referenced Oct 22, 2023
Open
Open
@mcollinamcollina added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Oct 23, 2023
@nodejs-github-botnodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 23, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 23, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/50203
✔ Done loading data for nodejs/node/pull/50203
----------------------------------- PR info ------------------------------------
Title stream: avoid getter for defaultEncoding (#50203)
Author Robert Nagy (@ronag)
Branch ronag:writable-default-encoding -> nodejs:main
Labels author ready, needs-ci
Commits 1
- stream: avoid getter for defaultEncoding
Committers 1
- Robert Nagy PR-URL: https://github.com/nodejs/node/pull/50203
Reviewed-By: Matteo Collina Reviewed-By: Benjamin Gruenbaum Reviewed-By: Yagiz Nizipli Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/50203
Reviewed-By: Matteo Collina Reviewed-By: Benjamin Gruenbaum Reviewed-By: Yagiz Nizipli Reviewed-By: Luigi Pinca --------------------------------------------------------------------------------
⚠ Commits were pushed since the last approving review:
⚠ - stream: avoid getter for defaultEncoding
ℹ This PR was created on Mon, 16 Oct 2023 18:49:29 GMT
✔ Approvals: 4
✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/50203#pullrequestreview-1681620676
✔ - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/50203#pullrequestreview-1682971946
✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/50203#pullrequestreview-1683007855
✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/50203#pullrequestreview-1683084786
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2023-10-21T20:28:41Z: https://ci.nodejs.org/job/node-test-pull-request/55103/
- Querying data for job/node-test-pull-request/55103/
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/6609871118

@ronag
ronag requested a review from mcollinaOctober 23, 2023 07:19
mcollina
mcollina approved these changes Oct 23, 2023
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollinamcollina added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Oct 23, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 23, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 8e814e3 into nodejs:mainOct 23, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 23, 2023

Copy link
Copy Markdown
Collaborator

Landed in 8e814e3

@github-actionsgithub-actionsBot mentioned this pull request Oct 24, 2023
Open
27 tasks
targos pushed a commit that referenced this pull request Nov 11, 2023
@ronag@targos
stream: avoid getter for defaultEncoding
766bd9c
PR-URL: #50203
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targostargos mentioned this pull request Nov 12, 2023
Merged
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@ronag@UlisesGascon
stream: avoid getter for defaultEncoding
b338f3d
PR-URL: #50203
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@UlisesGasconUlisesGascon mentioned this pull request Dec 12, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@mcollinamcollinamcollina approved these changes
@benjamingrbenjamingrbenjamingr approved these changes
@anonriganonriganonrig approved these changes
+3 more reviewers
@meyfameyfameyfa left review comments
@MifrillMifrillMifrill left review comments
@pacifiquempacifiquempacifiquem left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@ronag@nodejs-github-bot@mcollina@benjamingr@lpinca@anonrig@meyfa@Mifrill@pacifiquem