Skip to content

test: skip test-benchmark-os.js on IBM i - #50208

Closed
abmusse wants to merge 1 commit into
nodejs:mainfrom
abmusse:test-skip-test-benchmark-os
Closed

test: skip test-benchmark-os.js on IBM i#50208
abmusse wants to merge 1 commit into
nodejs:mainfrom
abmusse:test-skip-test-benchmark-os

Conversation

@abmusse

@abmusseabmusse commented Oct 17, 2023

Copy link
Copy Markdown
Contributor

This change skips the entire test-benchmark-os.js suite on IBM i. Currently this is failing due to os.uptime call:

node/benchmark/os/uptime.js

Line 4 in ea595eb

constuptime=require('os').uptime;

Instead of skipping the entire os benchmark suite, I would rather skip just the uptime benchmark
but I'm not sure how to achieve this. Anyone have any ideas to skip one of the os benchmarks?

CC
@nodejs/platform-ibmi
@richardlau
Fixes#50207

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Oct 17, 2023
@richardlaurichardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 17, 2023
@richardlaurichardlau added the ibm i Issues and PRs related to the IBM i platform. label Oct 17, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 17, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 17, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54879/

mhdawson
mhdawson approved these changes Oct 17, 2023
View reviewed changes

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawsonmhdawson added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 17, 2023
@github-actions

github-actionsBot commented Oct 17, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @mhdawson. Please 👍 to approve.

@mhdawson

mhdawson commented Oct 17, 2023

Copy link
Copy Markdown
Member

I have an idea on how to be more specific, but think it's good to land this quickly to get the nightly build back to green.

@nodejs-github-bot

nodejs-github-bot commented Oct 17, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54905/

@Uzlopak

Uzlopak commented Oct 17, 2023

Copy link
Copy Markdown
Contributor

I didnt know that the uptime is not working on ibm :/

Uzlopak
Uzlopak approved these changes Oct 17, 2023
View reviewed changes

@UzlopakUzlopak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created the benchmark and it is not a critical benchmark. It was just for demonstrating that the corresponding PR improves the performance.

We.should simply skip it.

@nodejs-github-bot

nodejs-github-bot commented Oct 18, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54945/

@nodejs-github-bot

nodejs-github-bot commented Oct 18, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54951/

@nodejs-github-bot

nodejs-github-bot commented Oct 18, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54964/

@abmusse

abmusse commented Oct 18, 2023

Copy link
Copy Markdown
ContributorAuthor

I didnt know that the uptime is not working on ibm :/
No worries 😄

I created the benchmark and it is not a critical benchmark. It was just for demonstrating that the corresponding PR improves the performance.

We.should simply skip it.

Yes we will look into how to skip this one individually but for now we will skip the benchmark until we get a patch ready.

mhdawson pushed a commit that referenced this pull request Oct 18, 2023
@abmusse@mhdawson
test: skip test-benchmark-os.js on IBM i
286fdaf
PR-URL: #50208
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@mhdawson

mhdawson commented Oct 18, 2023

Copy link
Copy Markdown
Member

Landed in 286fdaf

@abmusse
abmusse deleted the test-skip-test-benchmark-os branch October 18, 2023 19:48
This was referenced Oct 19, 2023
Open
Open
targos pushed a commit that referenced this pull request Oct 23, 2023
@abmusse@targos
test: skip test-benchmark-os.js on IBM i
3e38001
PR-URL: #50208
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@targostargos mentioned this pull request Oct 23, 2023
Merged
targos pushed a commit that referenced this pull request Nov 11, 2023
@abmusse@targos
test: skip test-benchmark-os.js on IBM i
f3296d2
PR-URL: #50208
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@targostargos mentioned this pull request Nov 12, 2023
Merged
@juanarboljuanarbol mentioned this pull request Dec 6, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardlaurichardlaurichardlau approved these changes
+2 more reviewers
@UzlopakUzlopakUzlopak approved these changes
@mhdawsonmhdawsonmhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fast-trackPRs that do not need to wait for 48 hours to land.ibm iIssues and PRs related to the IBM i platform.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test: benchmark/test-benchmark-os fails on IBM i

5 participants

@abmusse@nodejs-github-bot@mhdawson@Uzlopak@richardlau