permission: address coverity warning

[mhdawson]

The latest version of coverity has suggestions on how to improve formance. Address one of these suggestions.

[nodejs-github-bot]

Review requested:

• @nodejs/security-wg

[mhdawson]

Coverity has a new set of warnings. Seeing what we think about fixing those by starting with this one. If there is a possitive response I'd plan to fix in larget baches. The warning was:

212if (is_wildcard_node || is_last_char) {
213 std::string node_path = path.substr(parent_node_prefix_len, i);
CID329770 (#1 of 1): COPY_INSTEAD_OF_MOVE (COPY_INSTEAD_OF_MOVE)
1. copy_constructor_call: node_path is passed-by-value as parameter to CreateChild when it could be moved instead.
Use std::move(node_path) instead of node_path.
214 current_node = current_node->CreateChild(node_path);

[RafaelGSS]

Coverity has a new set of warnings. Seeing what we think about fixing those by starting with this one. If there is a possitive response I'd plan to fix in larget baches. The warning was:

212if (is_wildcard_node || is_last_char) {
213 std::string node_path = path.substr(parent_node_prefix_len, i);
CID329770 (#1 of 1): COPY_INSTEAD_OF_MOVE (COPY_INSTEAD_OF_MOVE)
1. copy_constructor_call: node_path is passed-by-value as parameter to CreateChild when it could be moved instead.
Use std::move(node_path) instead of node_path.
214 current_node = current_node->CreateChild(node_path);

Which compiler are you using? I didn't get these warnings building on macOS

➜ nodejs.org git:(v21-release) ✗ clang -v
Apple clang version 14.0.3 (clang-1403.0.22.14.1)

[mhdawson]

@RafaelGSS they are not from the compiler from but our Coverity static analysis - https://scan.coverity.com/projects/node-js

[bnoordhuis]

This doesn't really change anything (except maybe shut up coverity) because CreateChild takes a value, not a reference. What you want instead is this:

diff --git a/src/permission/fs_permission.h b/src/permission/fs_permission.h
index 244e95727a..80374a08c7 100644
--- a/src/permission/fs_permission.h+++ b/src/permission/fs_permission.h@@ -31,7 +31,7 @@ class FSPermission final : public PermissionBase {
Node() : wildcard_child(nullptr), is_leaf(false) {}
- Node* CreateChild(std::string prefix) {+ Node* CreateChild(const std::string& prefix) {
if (prefix.empty() && !is_leaf) {
is_leaf = true;
return this;

Or Node* CreateChild(std::string&& prefix) { + std::move(...). Look at other call sites to determine which is most appropriate.

[mhdawson]

@bnoordhuis thanks, updated

[RafaelGSS]

@mhdawson can you rebase?

[mhdawson]

@RafaelGSS rebased on squashed commits

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/55238/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/55252/

[mhdawson]

Landed in 3c1b4b3