Skip to content

test: set test-runner-watch-mode as flaky - #50221

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:test-update-win32-flake
Oct 18, 2023
Merged

test: set test-runner-watch-mode as flaky#50221
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:test-update-win32-flake

Conversation

@anonrig

@anonriganonrig commented Oct 17, 2023

Copy link
Copy Markdown
Member

Ref: #49985

cc @nodejs/test_runner

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Oct 17, 2023
@anonriganonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 17, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 17, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 17, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54907/

@GeoffreyBooth

GeoffreyBooth commented Oct 17, 2023

Copy link
Copy Markdown
Member

But #49997 is open to fix this.

@anonrig

anonrig commented Oct 17, 2023

Copy link
Copy Markdown
MemberAuthor

But #49997 is open to fix this.

@MoLow responded and said that the pr didn't fix the issue. Ref: #49997 (comment)

@anonrig
anonrig requested a review from jasnellOctober 18, 2023 01:03
@nodejs-github-bot

nodejs-github-bot commented Oct 18, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54916/

@anonriganonrig added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 18, 2023
@github-actions

github-actionsBot commented Oct 18, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @anonrig. Please 👍 to approve.

mcollina
mcollina approved these changes Oct 18, 2023
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
mcollina requested review from MoLow and cjihrigOctober 18, 2023 13:56
@anonriganonrig added commit-queue Add this label to land a pull request using GitHub Actions. flaky-test Issues and PRs related to the tests with unstable failures on the CI. labels Oct 18, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 18, 2023
@nodejs-github-bot
nodejs-github-bot merged commit aa8282e into nodejs:mainOct 18, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 18, 2023

Copy link
Copy Markdown
Collaborator

Landed in aa8282e

@github-actionsgithub-actionsBot mentioned this pull request Oct 19, 2023
Open
25 tasks
targos pushed a commit that referenced this pull request Oct 23, 2023
@anonrig@targos
test: set test-runner-watch-mode as flaky
8efb75f
PR-URL: #50221
Refs: #49985
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
@targostargos mentioned this pull request Oct 23, 2023
Merged
targos pushed a commit that referenced this pull request Nov 11, 2023
@anonrig@targos
test: set test-runner-watch-mode as flaky
c2c2506
PR-URL: #50221
Refs: #49985
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
@targostargos mentioned this pull request Nov 12, 2023
Merged
targos pushed a commit that referenced this pull request Nov 27, 2023
@anonrig@targos
test: set test-runner-watch-mode as flaky
5953a25
PR-URL: #50221
Refs: #49985
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
@targostargos mentioned this pull request Nov 28, 2023
Merged
@juanarboljuanarbol mentioned this pull request Dec 6, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test: set test-runner-watch-mode as flaky
dccc650
PR-URL: nodejs/node#50221
Refs: nodejs/node#49985
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test: set test-runner-watch-mode as flaky
530add0
PR-URL: nodejs/node#50221
Refs: nodejs/node#49985
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@cjihrigcjihrigcjihrig approved these changes
@ronagronagronag approved these changes
@jasnelljasnellAwaiting requested review from jasnell
@MoLowMoLowAwaiting requested review from MoLow

Assignees

No one assigned

Labels

fast-trackPRs that do not need to wait for 48 hours to land.flaky-testIssues and PRs related to the tests with unstable failures on the CI.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@anonrig@nodejs-github-bot@GeoffreyBooth@mcollina@cjihrig@ronag