Skip to content

test: set sea snapshot tests as flaky - #50223

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:set-snapshot-flaky
Oct 18, 2023
Merged

test: set sea snapshot tests as flaky#50223
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:set-snapshot-flaky

Conversation

@anonrig

@anonriganonrig commented Oct 17, 2023

Copy link
Copy Markdown
Member

Ref: #49630

cc @nodejs/single-executable

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Oct 17, 2023
@anonriganonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 17, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 17, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 17, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54908/

@anonrig
anonrig requested a review from jasnellOctober 18, 2023 01:03
@nodejs-github-bot

nodejs-github-bot commented Oct 18, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54919/

@nodejs-github-bot

nodejs-github-bot commented Oct 18, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54936/

@anonriganonrig added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Oct 18, 2023
@github-actions

github-actionsBot commented Oct 18, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @anonrig. Please 👍 to approve.

@mcollina
mcollina requested review from MoLow and cjihrigOctober 18, 2023 13:57
mcollina
mcollina approved these changes Oct 18, 2023
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anonriganonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 18, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 18, 2023
@nodejs-github-bot
nodejs-github-bot merged commit dab9505 into nodejs:mainOct 18, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 18, 2023

Copy link
Copy Markdown
Collaborator

Landed in dab9505

@github-actionsgithub-actionsBot mentioned this pull request Oct 19, 2023
Open
25 tasks
targos pushed a commit that referenced this pull request Oct 23, 2023
@anonrig@targos
test: set sea snapshot tests as flaky
143ddde
PR-URL: #50223
Refs: #49630
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@targostargos mentioned this pull request Oct 23, 2023
Merged
targos pushed a commit that referenced this pull request Nov 11, 2023
@anonrig@targos
test: set sea snapshot tests as flaky
16a0798
PR-URL: #50223
Refs: #49630
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@targostargos mentioned this pull request Nov 12, 2023
Merged
@joyeecheungjoyeecheung mentioned this pull request Nov 15, 2023
Closed
@juanarboljuanarbol mentioned this pull request Dec 6, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@cjihrigcjihrigcjihrig approved these changes
@RaisinTenRaisinTenRaisinTen approved these changes
@jasnelljasnellAwaiting requested review from jasnell
@MoLowMoLowAwaiting requested review from MoLow

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.fast-trackPRs that do not need to wait for 48 hours to land.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@anonrig@nodejs-github-bot@mcollina@cjihrig@RaisinTen