Skip to content

test: set parallel http server test as flaky - #50227

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:set-http-server-request-flaky
Oct 18, 2023
Merged

test: set parallel http server test as flaky#50227
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:set-http-server-request-flaky

Conversation

@anonrig

@anonriganonrig commented Oct 18, 2023

Copy link
Copy Markdown
Member

Ref: #43465

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Oct 18, 2023
@anonrig
anonrig requested a review from jasnellOctober 18, 2023 01:03
@anonriganonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 18, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 18, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 18, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54913/

@anonrig
anonrigforce-pushed the set-http-server-request-flaky branch from 183a4b1 to 5b57613CompareOctober 18, 2023 01:57
richardlau
richardlau reviewed Oct 18, 2023
View reviewed changes
Comment threadtest/parallel/parallel.status Outdated
@anonrig
anonrigforce-pushed the set-http-server-request-flaky branch from 5b57613 to d3ce6faCompareOctober 18, 2023 02:31
@anonriganonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 18, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 18, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 18, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54921/

@anonriganonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. labels Oct 18, 2023
@github-actions

github-actionsBot commented Oct 18, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @anonrig. Please 👍 to approve.

@nodejs-github-bot

nodejs-github-bot commented Oct 18, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54935/

@anonrig

anonrig commented Oct 18, 2023

Copy link
Copy Markdown
MemberAuthor

@richardlau@H4ad @nodejs/http can you approve the fast-track?

@anonriganonrig added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Oct 18, 2023
@lpinca

lpinca commented Oct 18, 2023

Copy link
Copy Markdown
Member

cc: @ShogunPanda

@anonriganonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 18, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 18, 2023
@nodejs-github-bot
nodejs-github-bot merged commit b3313bf into nodejs:mainOct 18, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 18, 2023

Copy link
Copy Markdown
Collaborator

Landed in b3313bf

targos pushed a commit that referenced this pull request Oct 23, 2023
@anonrig@targos
test: set parallel http server test as flaky
dd66fdf
Ref: #43465
PR-URL: #50227
Refs: #43465
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
@targostargos mentioned this pull request Oct 23, 2023
Merged
targos pushed a commit that referenced this pull request Nov 11, 2023
@anonrig@targos
test: set parallel http server test as flaky
fefe17b
Ref: #43465
PR-URL: #50227
Refs: #43465
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
@targostargos mentioned this pull request Nov 12, 2023
Merged
targos pushed a commit that referenced this pull request Nov 27, 2023
@anonrig@targos
test: set parallel http server test as flaky
cb0bd21
Ref: #43465
PR-URL: #50227
Refs: #43465
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
@targostargos mentioned this pull request Nov 28, 2023
Merged
@juanarboljuanarbol mentioned this pull request Dec 6, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test: set parallel http server test as flaky
ab2e360
Ref: nodejs/node#43465
PR-URL: nodejs/node#50227
Refs: nodejs/node#43465
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test: set parallel http server test as flaky
7c03263
Ref: nodejs/node#43465
PR-URL: nodejs/node#50227
Refs: nodejs/node#43465
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@panvapanvapanva approved these changes
@richardlaurichardlaurichardlau approved these changes
@H4adH4adH4ad approved these changes
@marco-ippolitomarco-ippolitomarco-ippolito approved these changes
@jasnelljasnellAwaiting requested review from jasnell

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.fast-trackPRs that do not need to wait for 48 hours to land.flaky-testIssues and PRs related to the tests with unstable failures on the CI.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@anonrig@nodejs-github-bot@lpinca@panva@richardlau@H4ad@marco-ippolito