Skip to content

lib: avoid memory allocation on no-deprecation flag - #50231

Merged
nodejs-github-bot merged 3 commits into
nodejs:mainfrom
H4ad:lib/early-stop-for-deprecation
Oct 30, 2023
Merged

lib: avoid memory allocation on no-deprecation flag#50231
nodejs-github-bot merged 3 commits into
nodejs:mainfrom
H4ad:lib/early-stop-for-deprecation

Conversation

@H4ad

@H4adH4ad commented Oct 18, 2023

Copy link
Copy Markdown
Member

Just some tiny changes inspired by nodejs/performance#90

@nodejs-github-bot

nodejs-github-bot commented Oct 18, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders

@nodejs-github-botnodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem. labels Oct 18, 2023
@anonriganonrig added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Oct 26, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 26, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 26, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55253/

aduh95
aduh95 reviewed Oct 26, 2023
View reviewed changes
Comment threadlib/internal/process/warning.js Outdated
This was referenced Oct 27, 2023
Open
Open
@H4ad
H4ad requested a review from aduh95October 28, 2023 00:43
@anonriganonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 28, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 28, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 28, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55293/

This was referenced Oct 29, 2023
Open
Open
@H4adH4ad added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Oct 30, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 30, 2023
@nodejs-github-bot
nodejs-github-bot merged commit dcaded0 into nodejs:mainOct 30, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 30, 2023

Copy link
Copy Markdown
Collaborator

Landed in dcaded0

@H4ad
H4ad deleted the lib/early-stop-for-deprecation branch October 30, 2023 20:52
@github-actionsgithub-actionsBot mentioned this pull request Oct 31, 2023
Open
17 tasks
targos pushed a commit that referenced this pull request Nov 11, 2023
@H4ad@targos
lib: avoid memory allocation on nodeprecation flag
811ce64
PR-URL: #50231
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targostargos mentioned this pull request Nov 12, 2023
Merged
targos pushed a commit that referenced this pull request Nov 14, 2023
@H4ad@targos
lib: avoid memory allocation on nodeprecation flag
6dabe7c
PR-URL: #50231
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@H4ad@UlisesGascon
lib: avoid memory allocation on nodeprecation flag
0a0b416
PR-URL: #50231
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@UlisesGasconUlisesGascon mentioned this pull request Dec 12, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@anonriganonriganonrig approved these changes
@aduh95aduh95Awaiting requested review from aduh95

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.esmIssues and PRs related to the ECMAScript Modules implementation.needs-ciPRs that need a full CI run.processIssues and PRs related to the process subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@H4ad@nodejs-github-bot@jasnell@anonrig@aduh95