Skip to content

doc: fix hardwareConcurrency example - #50278

Merged
aduh95 merged 1 commit into
nodejs:mainfrom
tniessen:navigator-is-bad
Oct 23, 2023
Merged

doc: fix hardwareConcurrency example#50278
aduh95 merged 1 commit into
nodejs:mainfrom
tniessen:navigator-is-bad

Conversation

@tniessen

@tniessentniessen commented Oct 19, 2023

Copy link
Copy Markdown
Member

Refs: #47769

@tniessentniessen added doc Issues and PRs related to the documentations. experimental Issues and PRs related to experimental features. labels Oct 19, 2023
@tniessentniessen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 19, 2023
@H4adH4ad added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 19, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 19, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 19, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55005/

@nodejs-github-bot

nodejs-github-bot commented Oct 19, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55017/

@nodejs-github-bot

nodejs-github-bot commented Oct 19, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55018/

Uzlopak
Uzlopak approved these changes Oct 19, 2023
View reviewed changes

@UzlopakUzlopak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tniessen

tniessen commented Oct 19, 2023

Copy link
Copy Markdown
MemberAuthor

@H4ad This PR did not need a Jenkins CI run because it touches documentation only.

@H4ad

H4ad commented Oct 19, 2023•
edited
Loading

Copy link
Copy Markdown
Member

@tniessen Oh, thanks for letting me know.

In cases like this, should we just fast-track or there is another behavior?

@tniessen

tniessen commented Oct 19, 2023•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

In cases like this, should we just fast-track or there is another behavior?

Any collaborator may suggest fast-tracking of such small doc-only changes by adding the fast-track label. But it's perfectly reasonable for a PR like this to wait for two days to land (without Jenkins CI) since it's not urgent by any means.

IIRC, now that Jenkins CI has been started, we have to run it until it passes for the commit queue to not reject the PR, but perhaps I am misremembering or things have changed.

This was referenced Oct 20, 2023
Open
Open
Open
@nodejs-github-bot

nodejs-github-bot commented Oct 22, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55113/

@nodejs-github-bot

nodejs-github-bot commented Oct 22, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55121/

@nodejs-github-bot

nodejs-github-bot commented Oct 22, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55122/

@tniessen

tniessen commented Oct 22, 2023

Copy link
Copy Markdown
MemberAuthor

Not sure what's going on with ARM...

@github-actionsgithub-actionsBot mentioned this pull request Oct 23, 2023
Open
26 tasks
@aduh95
aduh95 merged commit fa514c9 into nodejs:mainOct 23, 2023
@aduh95

aduh95 commented Oct 23, 2023

Copy link
Copy Markdown
Contributor

Landed in 5d33203

@github-actionsgithub-actionsBot mentioned this pull request Oct 24, 2023
Open
27 tasks
targos pushed a commit that referenced this pull request Oct 24, 2023
@tniessen@targos
doc: fix navigator.hardwareConcurrency example
db2a1cf
PR-URL: #50278
Refs: #47769
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targostargos mentioned this pull request Oct 24, 2023
Merged
@github-actionsgithub-actionsBot mentioned this pull request Oct 25, 2023
Open
16 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@anonriganonriganonrig approved these changes
@targostargostargos approved these changes
@richardlaurichardlaurichardlau approved these changes
@H4adH4adH4ad approved these changes
+2 more reviewers
@UzlopakUzlopakUzlopak approved these changes
@aymen94aymen94aymen94 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.experimentalIssues and PRs related to experimental features.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@tniessen@nodejs-github-bot@H4ad@aduh95@lpinca@anonrig@targos@Uzlopak@richardlau@aymen94