Skip to content

benchmark: skip test-benchmark-os on IBMi - #50286

Closed
mhdawson wants to merge 3 commits into
nodejs:mainfrom
mhdawson:excludelessibmi
Closed

benchmark: skip test-benchmark-os on IBMi#50286
mhdawson wants to merge 3 commits into
nodejs:mainfrom
mhdawson:excludelessibmi

Conversation

@mhdawson

@mhdawsonmhdawson commented Oct 19, 2023

Copy link
Copy Markdown
Member
  • IBMi does not have the os.uptime implemented so skip otherwise CI tests fail.

@mhdawson
benchmark: skip test-benchmark-os on IBMi
b899ab7
- IBMi does not have the os.uptime implemented so skip
otherwise CI tests fail.
Signed-off-by: Michael Dawson <midawson@redhat.com>
@nodejs-github-botnodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. needs-ci PRs that need a full CI run. performance Issues and PRs related to the performance of Node.js. test Issues and PRs related to the tests. labels Oct 19, 2023
Uzlopak
Uzlopak approved these changes Oct 19, 2023
View reviewed changes

@UzlopakUzlopak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson

mhdawson commented Oct 19, 2023

Copy link
Copy Markdown
MemberAuthor

CI run to confirm this skips the test on IBMi and the CI is green - https://ci.nodejs.org/view/All/job/node-test-commit-ibmi/1338/

@mhdawson
squash: address linter issues
5bb8b87
Signed-off-by: Michael Dawson <midawson@redhat.com>
@mhdawson

mhdawson commented Oct 19, 2023

Copy link
Copy Markdown
MemberAuthor

@abmusse FYI

H4ad
H4ad reviewed Oct 19, 2023
View reviewed changes
Comment threadbenchmark/run.js Outdated
@mhdawson
squash: address comments
42c2df2
Signed-off-by: Michael Dawson <midawson@redhat.com>
@mhdawson

mhdawson commented Oct 19, 2023

Copy link
Copy Markdown
MemberAuthor

@H4ad@anonrig that works for me as well, pushed commit to do it that way instead.

abmusse
abmusse approved these changes Oct 19, 2023
View reviewed changes

@abmusseabmusse left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson

mhdawson commented Oct 19, 2023

Copy link
Copy Markdown
MemberAuthor

CI to verify again that is passed on ibmi - https://ci.nodejs.org/view/All/job/node-test-commit-ibmi/1339/

H4ad
H4ad reviewed Oct 19, 2023
View reviewed changes
Comment threadbenchmark/os/uptime.js
Comment on lines +14 to +17
if (os.type() === 'OS400') {
console.log('Skipping: os.uptime is not implemented on IBMi');
process.exit(0);
}

@H4adH4adOct 19, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is better to put outside main, on top of the file, just not to have any weird behavior.

But is not a blocker for me, so do it if you agree.

@anonriganonrigOct 20, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mhdawson can you move this to a similar position like in other fs benchmarks?

@H4adH4ad added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 19, 2023
@mhdawsonmhdawson added request-ci Add this label to start a Jenkins CI on a PR. fast-track PRs that do not need to wait for 48 hours to land. labels Oct 20, 2023
@github-actions

github-actionsBot commented Oct 20, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @mhdawson. Please 👍 to approve.

@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 20, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 20, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55047/

@nodejs-github-bot

nodejs-github-bot commented Oct 20, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55057/

@nodejs-github-bot

nodejs-github-bot commented Oct 20, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55064/

This was referenced Oct 21, 2023
Open
Open
Open
@nodejs-github-bot

nodejs-github-bot commented Oct 23, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55166/

mhdawson added a commit that referenced this pull request Oct 24, 2023
@mhdawson
benchmark: skip test-benchmark-os on IBMi
abd8ff6
- IBMi does not have the os.uptime implemented so skip
otherwise CI tests fail.
Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: #50286
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@mhdawson

mhdawson commented Oct 24, 2023

Copy link
Copy Markdown
MemberAuthor

Landed in abd8ff6

targos pushed a commit that referenced this pull request Nov 11, 2023
@mhdawson@targos
benchmark: skip test-benchmark-os on IBMi
2006b57
- IBMi does not have the os.uptime implemented so skip
otherwise CI tests fail.
Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: #50286
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targostargos mentioned this pull request Nov 12, 2023
Merged
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@mhdawson@UlisesGascon
benchmark: skip test-benchmark-os on IBMi
dbe6c5f
- IBMi does not have the os.uptime implemented so skip
otherwise CI tests fail.
Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: #50286
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@UlisesGasconUlisesGascon mentioned this pull request Dec 12, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonriganonriganonrig approved these changes
@lpincalpincalpinca approved these changes
@richardlaurichardlaurichardlau approved these changes
@H4adH4adH4ad approved these changes
@abmusseabmusseabmusse approved these changes
+1 more reviewer
@UzlopakUzlopakUzlopak approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.benchmarkIssues and PRs related to the benchmark subsystem.fast-trackPRs that do not need to wait for 48 hours to land.needs-ciPRs that need a full CI run.performanceIssues and PRs related to the performance of Node.js.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@mhdawson@nodejs-github-bot@lpinca@anonrig@Uzlopak@richardlau@H4ad@abmusse