Skip to content

doc: explain how to disable navigator - #50310

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
GeoffreyBooth:navigator-note
Oct 22, 2023
Merged

doc: explain how to disable navigator#50310
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
GeoffreyBooth:navigator-note

Conversation

@GeoffreyBooth

@GeoffreyBoothGeoffreyBooth commented Oct 20, 2023

Copy link
Copy Markdown
Member

Per #50269 (comment), this adds a note about how to delete the navigator global if necessary. This also sets the experimental status level.

@GeoffreyBoothGeoffreyBooth added doc Issues and PRs related to the documentations. experimental Issues and PRs related to experimental features. dont-land-on-v18.x labels Oct 20, 2023
@GeoffreyBoothGeoffreyBooth added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 21, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 21, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55077/

@bnoordhuis

bnoordhuis commented Oct 21, 2023

Copy link
Copy Markdown
Member

Landing should wait until a decision has been made on whether or not to keep navigator around (IOW, blocked on #50269.)

@GeoffreyBooth

GeoffreyBooth commented Oct 21, 2023

Copy link
Copy Markdown
MemberAuthor

Landing should wait until a decision has been made on whether or not to keep navigator

No. We can always land this and remove the API.

@nodejs-github-bot

nodejs-github-bot commented Oct 21, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55090/

@nodejs-github-bot

nodejs-github-bot commented Oct 21, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55096/

@nodejs-github-bot

nodejs-github-bot commented Oct 21, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55097/

@nodejs-github-bot

nodejs-github-bot commented Oct 21, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55100/

@nodejs-github-bot

nodejs-github-bot commented Oct 21, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55102/

@GeoffreyBoothGeoffreyBooth added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 21, 2023
@github-actionsgithub-actionsBot mentioned this pull request Oct 22, 2023
Open
29 tasks
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 22, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 25576b5 into nodejs:mainOct 22, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 22, 2023

Copy link
Copy Markdown
Collaborator

Landed in 25576b5

@github-actionsgithub-actionsBot mentioned this pull request Oct 23, 2023
Open
26 tasks
targos pushed a commit that referenced this pull request Oct 23, 2023
@GeoffreyBooth@targos
doc: explain how to disable navigator
6e537ae
PR-URL: #50310
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@targostargos mentioned this pull request Oct 23, 2023
Merged
@github-actionsgithub-actionsBot mentioned this pull request Oct 24, 2023
Open
27 tasks
@GeoffreyBoothGeoffreyBooth mentioned this pull request Oct 26, 2023
Closed
@ljharb

ljharb commented Oct 26, 2023

Copy link
Copy Markdown
Member

cc @nodejs/web-standards since we weren't given a chance to weigh in before node's docs recommended a decades-old bad practice.

@aduh95

aduh95 commented Oct 26, 2023

Copy link
Copy Markdown
Contributor

Another issue with this recommendation if that --import runs after --require, so if the issue happens in a script that's being preloaded, users are out of luck.

@GeoffreyBooth
GeoffreyBooth deleted the navigator-note branch October 26, 2023 18:48
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonriganonriganonrig approved these changes
@MoLowMoLowMoLow approved these changes
@himself65himself65himself65 approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.experimentalIssues and PRs related to experimental features.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@GeoffreyBooth@nodejs-github-bot@bnoordhuis@ljharb@aduh95@anonrig@MoLow@himself65