Skip to content

test: improve watch mode test - #50319

Merged
nodejs-github-bot merged 3 commits into
nodejs:mainfrom
MoLow:fix-import-with-watch
Oct 23, 2023
Merged

test: improve watch mode test#50319
nodejs-github-bot merged 3 commits into
nodejs:mainfrom
MoLow:fix-import-with-watch

Conversation

@MoLow

@MoLowMoLow commented Oct 21, 2023

Copy link
Copy Markdown
Member

this test was changed to enable landing of #50096
the original intent was to make sure the --import is only handled by the inner process spawned by watch mode, and not the outer one.

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Oct 21, 2023
GeoffreyBooth
GeoffreyBooth approved these changes Oct 21, 2023
View reviewed changes

@GeoffreyBoothGeoffreyBooth left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

GeoffreyBooth
GeoffreyBooth reviewed Oct 21, 2023
View reviewed changes
Comment threadtest/sequential/test-watch-mode.mjs Outdated
@MoLowMoLow added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Oct 21, 2023
@MoLowMoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 21, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 21, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 21, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55107/

@MoLowMoLow added commit-queue Add this label to land a pull request using GitHub Actions. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Oct 22, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 23, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 41a3878 into nodejs:mainOct 23, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 23, 2023

Copy link
Copy Markdown
Collaborator

Landed in 41a3878

@MoLow
MoLow deleted the fix-import-with-watch branch October 23, 2023 19:04
targos pushed a commit that referenced this pull request Oct 24, 2023
@MoLow@targos
test: improve watch mode test
a9ca7b3
PR-URL: #50319
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@targostargos mentioned this pull request Oct 24, 2023
Merged
targos pushed a commit that referenced this pull request Nov 11, 2023
@MoLow@targos
test: improve watch mode test
7d8a18b
PR-URL: #50319
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@targostargos mentioned this pull request Nov 12, 2023
Merged
@juanarboljuanarbol mentioned this pull request Dec 6, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GeoffreyBoothGeoffreyBoothGeoffreyBooth approved these changes
@anonriganonriganonrig approved these changes
@cjihrigcjihrigcjihrig approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@MoLow@nodejs-github-bot@GeoffreyBooth@anonrig@cjihrig