Skip to content

deps: update ada to 2.7.2 - #50338

Merged
nodejs-github-bot merged 1 commit into
mainfrom
actions/tools-update-ada
Oct 23, 2023
Merged

deps: update ada to 2.7.2#50338
nodejs-github-bot merged 1 commit into
mainfrom
actions/tools-update-ada

Conversation

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

This is an automated update of ada to 2.7.2.

@nodejs-github-botnodejs-github-bot added the dependencies Pull requests that update a dependency file. label Oct 23, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 23, 2023

Copy link
Copy Markdown
CollaboratorAuthor

Review requested:

  • @nodejs/url

@nodejs-github-botnodejs-github-bot added the needs-ci PRs that need a full CI run. label Oct 23, 2023
@anonriganonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 23, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 23, 2023
@nodejs-github-bot

Copy link
Copy Markdown
CollaboratorAuthor

@anonriganonrig added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 23, 2023
@github-actions

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @anonrig. Please 👍 to approve.

@anonriganonrig mentioned this pull request Oct 23, 2023
@anonriganonrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 23, 2023
@anonrig

Copy link
Copy Markdown
Member

@nodejs/url @nodejs/tsc can you approve fast-track so that we can include this PR in latest 21 release?

@targos

Copy link
Copy Markdown
Member

Does it fix a known issue?

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anonrig

Copy link
Copy Markdown
Member

Does it fix a known issue?

It fixes 2 bugs.

@anonriganonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 23, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 23, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 19216ab into mainOct 23, 2023
@nodejs-github-bot
nodejs-github-bot deleted the actions/tools-update-ada branch October 23, 2023 16:44
@nodejs-github-bot

Copy link
Copy Markdown
CollaboratorAuthor

Landed in 19216ab

targos pushed a commit that referenced this pull request Oct 24, 2023
PR-URL: #50338
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
targos pushed a commit that referenced this pull request Oct 28, 2023
PR-URL: #50338
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
targos pushed a commit that referenced this pull request Nov 11, 2023
PR-URL: #50338
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
@targostargos mentioned this pull request Nov 12, 2023
@targostargos mentioned this pull request Nov 28, 2023
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
PR-URL: nodejs/node#50338
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
PR-URL: nodejs/node#50338
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.dependenciesPull requests that update a dependency file.fast-trackPRs that do not need to wait for 48 hours to land.needs-ciPRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@nodejs-github-bot@anonrig@targos@mcollina@H4ad