Skip to content

benchmark: add benchmarks for encodings - #50348

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
Uzlopak:benchmarks-encodings
Oct 25, 2023
Merged

benchmark: add benchmarks for encodings#50348
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
Uzlopak:benchmarks-encodings

Conversation

@Uzlopak

@UzlopakUzlopak commented Oct 23, 2023

Copy link
Copy Markdown
Contributor

Adds benchmarks for base64url and improves the benchmarks for hex

@nodejs-github-botnodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. buffer Issues and PRs related to the buffer subsystem. labels Oct 23, 2023
@UzlopakUzlopak mentioned this pull request Oct 23, 2023
Open
H4ad
H4ad reviewed Oct 23, 2023
View reviewed changes
Comment threadbenchmark/buffers/buffer-hex-decoded.js Outdated
Comment threadbenchmark/buffers/buffer-base64url-encode.js Outdated
Comment threadbenchmark/buffers/buffer-base64url-decode.js Outdated
@Uzlopak
Uzlopakforce-pushed the benchmarks-encodings branch from e68c850 to e76e90aCompareOctober 23, 2023 22:35
@Uzlopak

Uzlopak commented Oct 23, 2023

Copy link
Copy Markdown
ContributorAuthor

@H4ad
done

@Uzlopak
Uzlopakforce-pushed the benchmarks-encodings branch from e76e90a to 6ee3a1fCompareOctober 23, 2023 22:39
@H4adH4ad added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 24, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 24, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 24, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55184/

@H4adH4ad added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 24, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 25, 2023
@nodejs-github-bot
nodejs-github-bot merged commit d895130 into nodejs:mainOct 25, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 25, 2023

Copy link
Copy Markdown
Collaborator

Landed in d895130

@Uzlopak
Uzlopak deleted the benchmarks-encodings branch October 25, 2023 20:52
targos pushed a commit that referenced this pull request Nov 11, 2023
@Uzlopak@targos
benchmark: add benchmarks for encodings
3f37ed9
PR-URL: #50348
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@targostargos mentioned this pull request Nov 12, 2023
Merged
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@Uzlopak@UlisesGascon
benchmark: add benchmarks for encodings
15c2ed9
PR-URL: #50348
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@UlisesGasconUlisesGascon mentioned this pull request Dec 12, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonriganonriganonrig approved these changes
@H4adH4adH4ad approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.benchmarkIssues and PRs related to the benchmark subsystem.bufferIssues and PRs related to the buffer subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Uzlopak@nodejs-github-bot@anonrig@H4ad