Uh oh!
There was an error while loading. Please reload this page.
tests: New zlib version is 1.3, which only has two elements - #50364
Conversation
DimStar77
commented
Oct 24, 2023
Background:
With this constellation, the test suite failed with |
In the past, zlib versions had major.minor.micro formats, but with 1.3 this has been changed. Change the test code to accept one, two, or three elements past the major version.
I think a better approach would be to skip the assertion when Node.js is built with the |
Neverming, commit message is ok. I was tricked by PR title. |
richardlau
commented
Nov 1, 2023
Commit message looks okay (it was already changed from the PR title). |
nodejs-github-bot
commented
Nov 1, 2023
DimStar77
commented
Nov 1, 2023
My bad - that was the 'original' commit message, saw the bot complaining about this and rewrote it - hopefully to comply |
nodejs-github-bot
commented
Nov 2, 2023
nodejs-github-bot
commented
Nov 2, 2023
Landed in 5d01042 |
In the past, zlib versions had major.minor.micro formats, but with 1.3 this has been changed. Change the test code to accept one, two, or three elements past the major version. PR-URL: #50364 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
In the past, zlib versions had major.minor.micro formats, but with 1.3 this has been changed. Change the test code to accept one, two, or three elements past the major version. PR-URL: #50364 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
In the past, zlib versions had major.minor.micro formats, but with 1.3 this has been changed. Change the test code to accept one, two, or three elements past the major version. PR-URL: #50364 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
In the past, zlib versions had major.minor.micro formats, but with 1.3 this has been changed. Change the test code to accept one, two, or three elements past the major version. PR-URL: #50364 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
In the past, zlib versions had major.minor.micro formats, but with 1.3 this has been changed. Change the test code to accept one, two, or three elements past the major version. PR-URL: nodejs/node#50364 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
In the past, zlib versions had major.minor.micro formats, but with 1.3 this has been changed. Change the test code to accept one, two, or three elements past the major version. PR-URL: nodejs/node#50364 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
Change the test code to accept one, two, or three elements past the major version