Skip to content

src: ReadIterable entries may be empty - #50398

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
KhafraDev:readiterable-assertion
Oct 27, 2023
Merged

src: ReadIterable entries may be empty#50398
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
KhafraDev:readiterable-assertion

Conversation

@KhafraDev

@KhafraDevKhafraDev commented Oct 25, 2023

Copy link
Copy Markdown
Member

Fixes#49940

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Oct 25, 2023
@KhafraDev
KhafraDevforce-pushed the readiterable-assertion branch from ee40112 to 4ab7c8aCompareOctober 25, 2023 21:31
@KhafraDev
KhafraDevforce-pushed the readiterable-assertion branch from 4ab7c8a to 14cbdf2CompareOctober 25, 2023 22:55
@anonriganonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 25, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 25, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 25, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55240/

@anonriganonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 27, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 27, 2023
@nodejs-github-bot
nodejs-github-bot merged commit e2cf2f0 into nodejs:mainOct 27, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 27, 2023

Copy link
Copy Markdown
Collaborator

Landed in e2cf2f0

@Alexey0312Alexey0312 mentioned this pull request Oct 27, 2023
Merged
@KhafraDev
KhafraDev deleted the readiterable-assertion branch October 27, 2023 22:19
targos pushed a commit that referenced this pull request Nov 11, 2023
@KhafraDev@targos
src: readiterable entries may be empty
4eb74a2
fixup
PR-URL: #50398
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
@targostargos mentioned this pull request Nov 12, 2023
Merged
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@KhafraDev@UlisesGascon
src: readiterable entries may be empty
b7ecb0a
fixup
PR-URL: #50398
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
@UlisesGasconUlisesGascon mentioned this pull request Dec 12, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonriganonriganonrig approved these changes
@H4adH4adH4ad approved these changes
+1 more reviewer
@debadree25debadree25debadree25 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

MessagePort.postMessage with custom iterator as transfer list causes Assertion `(index) < (length())' failed.

5 participants

@KhafraDev@nodejs-github-bot@anonrig@H4ad@debadree25