Skip to content

events: setting event cancelBubble calls stopPropagation - #50405

Closed
mertcanaltin wants to merge 3 commits into
nodejs:mainfrom
mertcanaltin:dev-50401
Closed

events: setting event cancelBubble calls stopPropagation#50405
mertcanaltin wants to merge 3 commits into
nodejs:mainfrom
mertcanaltin:dev-50401

Conversation

@mertcanaltin

@mertcanaltinmertcanaltin commented Oct 26, 2023

Copy link
Copy Markdown
Member

issue: #50401

In this issue, we addressed the problem where setting cancelBubble to true unintentionally called the stopPropagation method. The solution ensures that stopPropagation is only called when cancelBubble is explicitly set to false, as it should be. This change prevents the method from being called when cancelBubble is true or not explicitly set

@nodejs-github-botnodejs-github-bot added the needs-ci PRs that need a full CI run. label Oct 26, 2023
@mertcanaltinmertcanaltin added events Issues and PRs related to the events subsystem / EventEmitter. eventtarget Issues and PRs related to the EventTarget implementation. labels Oct 26, 2023
deokjinkim
deokjinkim reviewed Oct 26, 2023
View reviewed changes
Comment threadlib/internal/event_target.js Outdated
@mertcanaltin@deokjinkim
Update lib/internal/event_target.js
b1fc248
Co-authored-by: Deokjin Kim <deokjin81.kim@gmail.com>
@anonrig

anonrig commented Oct 26, 2023

Copy link
Copy Markdown
Member

Can you add a test?

benjamingr
benjamingr requested changes Oct 26, 2023
View reviewed changes

@benjamingrbenjamingr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test, changes lgtm

@mertcanaltin

mertcanaltin commented Nov 12, 2023•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

ı added a test

jeanbern
jeanbern reviewed Nov 16, 2023
View reviewed changes
Comment threadlib/internal/event_target.js
throw new ERR_INVALID_THIS('Event');
if (value) {
this.stopPropagation();
this.#propagationStopped = true;

@jeanbernjeanbernNov 16, 2023•
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is setting cancelBubble supposed to be one-way? The proposed change doesn't modify this.#propagationStopped when value is false

nvm: For anyone else wondering the same thing see here: whatwg/dom#211

@Scout2012Scout2012 mentioned this pull request Dec 6, 2023
Closed
@deokjinkimdeokjinkim added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 9, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 9, 2023
@nodejs-github-bot

nodejs-github-bot commented Dec 9, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56173/

@nodejs-github-bot

nodejs-github-bot commented Dec 25, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56522/

@mertcanaltin

mertcanaltin commented Dec 30, 2023

Copy link
Copy Markdown
MemberAuthor

I wonder if I should do an update here?

@nodejs-github-bot

nodejs-github-bot commented Dec 31, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56603/

@nodejs-github-bot

nodejs-github-bot commented Jan 1, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56621/

@nodejs-github-bot

nodejs-github-bot commented Jan 2, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56624/

@mertcanaltinmertcanaltin added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 3, 2024
@mertcanaltinmertcanaltin removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 3, 2024
@mertcanaltin

mertcanaltin commented Jan 6, 2024

Copy link
Copy Markdown
MemberAuthor

I guess flakky was the test 🤔 💭

@benjamingrbenjamingr added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 6, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 6, 2024
@nodejs-github-bot

nodejs-github-bot commented Jan 6, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56696/

@nodejs-github-bot

nodejs-github-bot commented Jan 9, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56723/

@mertcanaltinmertcanaltin added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 17, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 17, 2024
@nodejs-github-bot

nodejs-github-bot commented Jan 17, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56821/

@nodejs-github-bot

nodejs-github-bot commented Jan 21, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56862/

@mertcanaltin

mertcanaltin commented Jan 21, 2024

Copy link
Copy Markdown
MemberAuthor

passed 🎉🚀

@mertcanaltin

mertcanaltin commented Jan 25, 2024

Copy link
Copy Markdown
MemberAuthor

@benjamingr I would be very happy if you can make an update here, now it seems to have passed all the tests

@mertcanaltinmertcanaltin added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 18, 2024
mhdawson
mhdawson approved these changes Feb 26, 2024
View reviewed changes

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson

mhdawson commented Feb 26, 2024

Copy link
Copy Markdown
Member

@mertcanaltin I'm getting this warnings when landing -
GitHub cannot link the author of 'events: setting event cancelBubble calls stopPropagation' to their GitHub account.
⚠ Please suggest them to take a look at https://github.com/nodejs/node/blob/99b1ada/doc/guides/contributing/pull-requests.md#step-1-fork

Can you take a look? I'll land anyway but would be good to get that fixed up.

mhdawson pushed a commit that referenced this pull request Feb 26, 2024
mert.altin@mhdawson
events: no stopPropagation call in cancelBubble
399654f
PR-URL: #50405
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@mhdawson

mhdawson commented Feb 26, 2024

Copy link
Copy Markdown
Member

Landed in 399654f

@mertcanaltin

mertcanaltin commented Feb 27, 2024

Copy link
Copy Markdown
MemberAuthor

I am very sorry for the late response, thank you very much for correcting me @mhdawson ❤️ 🚀

marco-ippolito pushed a commit that referenced this pull request Feb 27, 2024
mert.altin@marco-ippolito
events: no stopPropagation call in cancelBubble
78f8180
PR-URL: #50405
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@marco-ippolitomarco-ippolito mentioned this pull request Mar 1, 2024
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
mert.altin@richardlau
events: no stopPropagation call in cancelBubble
d9b5cd5
PR-URL: #50405
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@richardlaurichardlau mentioned this pull request Mar 25, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@benjamingrbenjamingrbenjamingr approved these changes
@deokjinkimdeokjinkimdeokjinkim approved these changes
@KhafraDevKhafraDevKhafraDev approved these changes
+2 more reviewers
@jeanbernjeanbernjeanbern left review comments
@mhdawsonmhdawsonmhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.eventsIssues and PRs related to the events subsystem / EventEmitter.eventtargetIssues and PRs related to the EventTarget implementation.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@mertcanaltin@anonrig@nodejs-github-bot@mhdawson@jasnell@jeanbern@benjamingr@deokjinkim@KhafraDev