Skip to content

stream: use bit fields for construct/destroy - #50408

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
nxtedition:bitmap-constructor-destroy
Oct 28, 2023
Merged

stream: use bit fields for construct/destroy#50408
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
nxtedition:bitmap-constructor-destroy

Conversation

@ronag

@ronagronag commented Oct 26, 2023

Copy link
Copy Markdown
Member

No description provided.

@ronag
ronag requested a review from rluvatonOctober 26, 2023 13:47
@nodejs-github-bot

nodejs-github-bot commented Oct 26, 2023•
edited by ronag
Loading

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/streams

@nodejs-github-botnodejs-github-bot added the needs-ci PRs that need a full CI run. label Oct 26, 2023
@ronag

ronag commented Oct 26, 2023

Copy link
Copy Markdown
MemberAuthor

https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1459/

@ronag
ronagforce-pushed the bitmap-constructor-destroy branch from 6a5c0d6 to 3bf4eafCompareOctober 26, 2023 13:47
@ronag
ronagforce-pushed the bitmap-constructor-destroy branch from 3bf4eaf to 02e3f43CompareOctober 26, 2023 14:00
@ronag
ronagforce-pushed the bitmap-constructor-destroy branch from 02e3f43 to 74712a7CompareOctober 26, 2023 14:02
mcollina
mcollina approved these changes Oct 26, 2023
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ronagronag added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Oct 26, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 26, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 26, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55255/

rluvaton
rluvaton approved these changes Oct 26, 2023
View reviewed changes
Comment threadlib/internal/streams/utils.js Outdated
Comment on lines 26 to 34

@rluvatonrluvatonOct 26, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can we enforce that readable/writable stream will not have a bit state with the same position?

@ronagronagOct 26, 2023

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure. Suggestions?

Comment threadlib/internal/streams/destroy.js Outdated
@ronag
ronagforce-pushed the bitmap-constructor-destroy branch from 74712a7 to 763eaa1CompareOctober 26, 2023 14:52
@github-actionsgithub-actionsBot mentioned this pull request Oct 27, 2023
Open
19 tasks
@ronag
ronagforce-pushed the bitmap-constructor-destroy branch from 763eaa1 to cea0fb4CompareOctober 27, 2023 07:00
@ronagronag added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 27, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 27, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 27, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55264/

@nodejs-github-bot

nodejs-github-bot commented Oct 27, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55267/

@anonrig

anonrig commented Oct 27, 2023

Copy link
Copy Markdown
Member

@ronag If the motivation of this change is performance, can you share the benchmarks?

@ronag

ronag commented Oct 27, 2023

Copy link
Copy Markdown
MemberAuthor

There is a CI benchmark

@ronagronag added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 27, 2023
@github-actionsgithub-actionsBot mentioned this pull request Oct 28, 2023
Open
22 tasks
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 28, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 4c3dde9 into nodejs:mainOct 28, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 28, 2023

Copy link
Copy Markdown
Collaborator

Landed in 4c3dde9

This was referenced Oct 29, 2023
Open
Open
Open
targos pushed a commit that referenced this pull request Nov 11, 2023
@ronag@targos
stream: use bit fields for construct/destroy
03c4ff7
PR-URL: #50408
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@targostargos mentioned this pull request Nov 12, 2023
Merged
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@ronag@UlisesGascon
stream: use bit fields for construct/destroy
98ae1b4
PR-URL: #50408
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@UlisesGasconUlisesGascon mentioned this pull request Dec 12, 2023
Merged
@dead-claudiadead-claudia mentioned this pull request Feb 12, 2024
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@benjamingrbenjamingrbenjamingr approved these changes
@anonriganonriganonrig approved these changes
@rluvatonrluvatonrluvaton approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ronag@nodejs-github-bot@anonrig@mcollina@benjamingr@rluvaton