stream: fix Writable.destroy performance regression by ronag · Pull Request #50409 · nodejs/node

ronag · 2023-10-26T13:53:21Z

No description provided.

PR-URL: nodejs#50409

nodejs-github-bot · 2023-10-26T13:53:26Z

Review requested:

@nodejs/streams

ronag · 2023-10-26T13:58:47Z

https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1460/

mcollina

lgtm

nodejs-github-bot · 2023-10-26T14:26:30Z

CI: https://ci.nodejs.org/job/node-test-pull-request/55254/

nodejs-github-bot · 2023-10-27T04:42:16Z

CI: https://ci.nodejs.org/job/node-test-pull-request/55263/

nodejs-github-bot · 2023-10-27T10:42:36Z

CI: https://ci.nodejs.org/job/node-test-pull-request/55266/

nodejs-github-bot · 2023-10-28T14:03:30Z

Commit Queue failed

- Loading data for nodejs/node/pull/50409
✔ Done loading data for nodejs/node/pull/50409
----------------------------------- PR info ------------------------------------
Title stream: fix Writable.destroy performance regression (#50409)
Author Robert Nagy (@ronag)
Branch ronag:writable-destroy-pref -> nodejs:main
Labels performance, author ready, needs-ci
Commits 1
- stream: fix Writable.destroy performance regression
Committers 1
- Robert Nagy PR-URL: https://github.com/nodejs/node/pull/50409
Reviewed-By: Raz Luvaton Reviewed-By: Matteo Collina Reviewed-By: Benjamin Gruenbaum ------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/50409
Reviewed-By: Raz Luvaton Reviewed-By: Matteo Collina Reviewed-By: Benjamin Gruenbaum --------------------------------------------------------------------------------
ℹ This PR was created on Thu, 26 Oct 2023 13:53:21 GMT
✔ Approvals: 3
✔ - Raz Luvaton (@rluvaton): https://github.com/nodejs/node/pull/50409#pullrequestreview-1699727857
✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/50409#pullrequestreview-1699783397
✔ - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/50409#pullrequestreview-1700754946
✘ Last GitHub CI failed
ℹ Last Benchmark CI on 2023-10-26T13:58:47Z: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1460/
ℹ Last Full PR CI on 2023-10-27T10:42:36Z: https://ci.nodejs.org/job/node-test-pull-request/55266/
- Querying data for job/node-test-pull-request/55266/
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/6677348142

nodejs-github-bot · 2023-10-28T18:01:12Z

Commit Queue failed

- Loading data for nodejs/node/pull/50409
✔ Done loading data for nodejs/node/pull/50409
----------------------------------- PR info ------------------------------------
Title stream: fix Writable.destroy performance regression (#50409)
Author Robert Nagy (@ronag)
Branch ronag:writable-destroy-pref -> nodejs:main
Labels performance, author ready, needs-ci
Commits 1
- stream: fix Writable.destroy performance regression
Committers 1
- Robert Nagy PR-URL: https://github.com/nodejs/node/pull/50409
Reviewed-By: Raz Luvaton Reviewed-By: Matteo Collina Reviewed-By: Benjamin Gruenbaum Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/50409
Reviewed-By: Raz Luvaton Reviewed-By: Matteo Collina Reviewed-By: Benjamin Gruenbaum Reviewed-By: James M Snell --------------------------------------------------------------------------------
ℹ This PR was created on Thu, 26 Oct 2023 13:53:21 GMT
✔ Approvals: 4
✔ - Raz Luvaton (@rluvaton): https://github.com/nodejs/node/pull/50409#pullrequestreview-1699727857
✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/50409#pullrequestreview-1699783397
✔ - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/50409#pullrequestreview-1700754946
✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/50409#pullrequestreview-1702808873
✘ Last GitHub CI failed
ℹ Last Benchmark CI on 2023-10-28T14:03:30Z: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1460/
ℹ Last Full PR CI on 2023-10-28T14:03:30Z: https://ci.nodejs.org/job/node-test-pull-request/55266/
- Querying data for job/node-test-pull-request/1460/
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/6678407207

Trott · 2023-10-30T23:17:24Z

For whatever reason, this is failing the coverage-without-intl job over and over on GitHub Actions. I applied this change on top of current main (preserving commit authorship) and that passed over in #50478. So I'll run a full CI there. If the folks who approved this PR could also approve that one so it can land (and this one can be closed), that would be great.

@mcollina @jasnell @benjamingr @rluvaton

Trott · 2023-10-31T20:27:52Z

#50478 is exactly this PR but rebased. CI is passing on that PR and it is ready to land, but needs one more approval. If someone who approved this PR would approve that one, we could add the commit-queue label to that PR and close this one.

Ref: nodejs#50409 PR-URL: nodejs#50478 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Ref: #50409 PR-URL: #50478 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

ronag requested review from mcollina and rluvaton October 26, 2023 13:53

stream: fix Writable.destroy performance regression
c3403b4
PR-URL: nodejs#50409

nodejs-github-bot added the needs-ci PRs that need a full CI run. label Oct 26, 2023

ronag force-pushed the writable-destroy-pref branch from fe83419 to c3403b4Compare October 26, 2023 13:53

rluvaton approved these changes Oct 26, 2023
View reviewed changes

ronag added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Oct 26, 2023

mcollina approved these changes Oct 26, 2023
View reviewed changes

Uzlopak approved these changes Oct 26, 2023
View reviewed changes

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 26, 2023

rluvaton added the performance Issues and PRs related to the performance of Node.js. label Oct 26, 2023

benjamingr approved these changes Oct 26, 2023
View reviewed changes

github-actionsBot mentioned this pull request Oct 27, 2023
CI Reliability 2023-10-27 nodejs/reliability#699
Open
19 tasks

ronag added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 27, 2023

github-actionsBot mentioned this pull request Oct 28, 2023
CI Reliability 2023-10-28 nodejs/reliability#700
Open
22 tasks

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 28, 2023

nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Oct 28, 2023

jasnell approved these changes Oct 28, 2023
View reviewed changes

ronag added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Oct 28, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 28, 2023

nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Oct 28, 2023

This was referenced Oct 29, 2023
CI Reliability 2023-10-29 nodejs/reliability#701
Open
CI Reliability 2023-10-30 nodejs/reliability#702
Open

Trott mentioned this pull request Oct 30, 2023
stream: fix Writable.destroy performance regression #50478
Merged

github-actionsBot mentioned this pull request Oct 31, 2023
CI Reliability 2023-10-31 nodejs/reliability#703
Open
17 tasks

ronag closed this Oct 31, 2023

targos pushed a commit that referenced this pull request Nov 11, 2023
stream: fix Writable.destroy performance regression
3674ad5
Ref: #50409 PR-URL: #50478 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

targos pushed a commit that referenced this pull request Nov 14, 2023
stream: fix Writable.destroy performance regression
360f5d9
Ref: #50409 PR-URL: #50478 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Navigation Menu

Uh oh!

Uh oh!

stream: fix Writable.destroy performance regression - #50409

stream: fix Writable.destroy performance regression#50409
ronag wants to merge 1 commit into
nodejs:mainfrom
nxtedition:writable-destroy-pref

ronag commented Oct 26, 2023

Uh oh!

nodejs-github-bot commented Oct 26, 2023•
edited by ronag
Loading

Uh oh!

ronag commented Oct 26, 2023

Uh oh!

mcollina left a comment

Uh oh!

nodejs-github-bot commented Oct 26, 2023

Uh oh!

nodejs-github-bot commented Oct 27, 2023

Uh oh!

nodejs-github-bot commented Oct 27, 2023

Uh oh!

nodejs-github-bot commented Oct 28, 2023

Uh oh!

nodejs-github-bot commented Oct 28, 2023

Uh oh!

Trott commented Oct 30, 2023

Uh oh!

Trott commented Oct 31, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

Uh oh!

Conversation

ronag commented Oct 26, 2023

Uh oh!

nodejs-github-bot commented Oct 26, 2023• edited by ronag Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ronag commented Oct 26, 2023

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Oct 26, 2023

Uh oh!

nodejs-github-bot commented Oct 27, 2023

Uh oh!

nodejs-github-bot commented Oct 27, 2023

Uh oh!

nodejs-github-bot commented Oct 28, 2023

Uh oh!

nodejs-github-bot commented Oct 28, 2023

Uh oh!

Trott commented Oct 30, 2023

Uh oh!

Trott commented Oct 31, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

nodejs-github-bot commented Oct 26, 2023•
edited by ronag
Loading