Uh oh!
There was an error while loading. Please reload this page.
deps: update OpenSSL to 3.0.12+quic1 - #50411
Closed
nodejs-github-bot wants to merge 2 commits into
Closed
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
richardlau
commented
Oct 26, 2023
Member
For reference, this PR was generated by https://github.com/nodejs/node/actions/runs/6655826163/job/18086969161 (we should get the workflow to add this link to the PR). |
richardlau
commented
Oct 26, 2023
Member
I've canceled that run as it was started too early -- some of the platforms were only building the first commit (and the ones started later both commits). We'll probably need #50395 to land first for the tests to pass on this version of OpenSSL. |
RafaelGSS
approved these changes
Oct 26, 2023
This comment was marked as outdated.
This comment was marked as outdated.
richardlauforce-pushed
the
actions/tools-update-openssl
branch
from
October 27, 2023 23:45
17be836 to
b1dd1feComparerichardlau
commented
Oct 27, 2023
Member
I've rebased this PR to pick up #50395 so the GitHub action runs can pass. |
nodejs-github-bot
commented
Oct 27, 2023
CollaboratorAuthor
nodejs-github-bot
commented
Oct 28, 2023
CollaboratorAuthor
nodejs-github-bot
commented
Oct 28, 2023
CollaboratorAuthor
jasnell
approved these changes
Oct 28, 2023
nodejs-github-bot
commented
Oct 28, 2023
CollaboratorAuthor
Landed in d1592bd...116b28c |
nodejs-github-bot added a commit
that referenced
this pull request
Oct 28, 2023
PR-URL: #50411 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
21 tasks
This was referenced Oct 30, 2023
@richardlau@jasnell@RafaelGSS It seems reasonable that this upgrade should also be backported to 18.x since it is security related (albeit low, as already mentioned on the node.js blog post) so that it's in place for the next release cycle. What's the process to run the openssl updater against older branches, or would it make sense to just do a manual cherry-pick of this commit to the 18.x branch? I see the edit: I seem to have jumped the gun a bit before reading the backporting docs, so I found that the label does in fact mean that the releaser will have an eye on this PR to backport to 18.x when the time is right. |
RafaelGSS
commented
Nov 10, 2023
Member
When creating the v18 proposal it should be cherry-picked. |
targos pushed a commit
that referenced
this pull request
Nov 11, 2023
PR-URL: #50411 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit
that referenced
this pull request
Nov 11, 2023
PR-URL: #50411 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit
that referenced
this pull request
Nov 15, 2023
PR-URL: #50411 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit
that referenced
this pull request
Nov 15, 2023
PR-URL: #50411 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit
that referenced
this pull request
Nov 15, 2023
PR-URL: #50411 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit
that referenced
this pull request
Nov 15, 2023
PR-URL: #50411 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
sercher added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
PR-URL: nodejs/node#50411 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
sercher added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
PR-URL: nodejs/node#50411 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
sercher added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
PR-URL: nodejs/node#50411 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
sercher added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
PR-URL: nodejs/node#50411 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated update of OpenSSL to 3.0.12+quic1.