Skip to content

src: use BignumPointer and use BN_clear_free - #50454

Closed
jasnell wants to merge 1 commit into
nodejs:mainfrom
jasnell:crypto-use-bignum-pointer
Closed

src: use BignumPointer and use BN_clear_free#50454
jasnell wants to merge 1 commit into
nodejs:mainfrom
jasnell:crypto-use-bignum-pointer

Conversation

@jasnell

Copy link
Copy Markdown
Member

No description provided.

@jasnelljasnell added crypto Issues and PRs related to the crypto subsystem. lib / src Issues and PRs related to general changes in the lib or src directory. labels Oct 28, 2023
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Oct 28, 2023
@jasnell
jasnellforce-pushed the crypto-use-bignum-pointer branch from 0b1c533 to bb52365CompareOctober 28, 2023 20:20
Comment threadsrc/crypto/crypto_dh.cc Outdated
@jasnell
jasnellforce-pushed the crypto-use-bignum-pointer branch from bb52365 to b55c6ddCompareNovember 12, 2023 17:04
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

Comment threadsrc/crypto/crypto_dh.cc Outdated
@jasnell
jasnellforce-pushed the crypto-use-bignum-pointer branch from b55c6dd to 7dd07c1CompareDecember 22, 2023 02:17
@jasnelljasnell added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 22, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 22, 2023
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

nodejs-github-bot commented Dec 22, 2023

Copy link
Copy Markdown
Collaborator

@jasnell
jasnellforce-pushed the crypto-use-bignum-pointer branch from 7dd07c1 to f7ff63eCompareDecember 22, 2023 04:47
jasnell added a commit that referenced this pull request Dec 22, 2023
PR-URL: #50454
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@jasnell

Copy link
Copy Markdown
MemberAuthor

Landed in 1523650

@jasnelljasnell closed this Dec 22, 2023
RafaelGSS pushed a commit that referenced this pull request Jan 2, 2024
PR-URL: #50454
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request Jan 2, 2024
richardlau pushed a commit that referenced this pull request Mar 25, 2024
PR-URL: #50454
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@richardlaurichardlau mentioned this pull request Mar 25, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++Issues and PRs that require attention from people who are familiar with C++.cryptoIssues and PRs related to the crypto subsystem.lib / srcIssues and PRs related to general changes in the lib or src directory.needs-ciPRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@jasnell@nodejs-github-bot@tniessen@joyeecheung