Skip to content

deps: update cjs-module-lexer to 1.4.0 - #50458

Closed
nodejs-github-bot wants to merge 4 commits into
mainfrom
actions/tools-update-cjs-module-lexer
Closed

deps: update cjs-module-lexer to 1.4.0#50458
nodejs-github-bot wants to merge 4 commits into
mainfrom
actions/tools-update-cjs-module-lexer

Conversation

@nodejs-github-bot

@nodejs-github-botnodejs-github-bot commented Oct 29, 2023

Copy link
Copy Markdown
Collaborator

This is an automated update of cjs-module-lexer to 1.4.0.

@nodejs-github-botnodejs-github-bot added dependencies Pull requests that update a dependency file. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Oct 29, 2023
@nodejs-github-botnodejs-github-bot changed the title deps: update cjs-module-lexer to 1.2.3deps: update cjs-module-lexer to 1.3.0Apr 28, 2024
@nodejs-github-botnodejs-github-bot changed the title deps: update cjs-module-lexer to 1.3.0deps: update cjs-module-lexer to 1.3.1May 5, 2024
@marco-ippolito
marco-ippolitoforce-pushed the actions/tools-update-cjs-module-lexer branch from 8272d33 to 403c144CompareMay 8, 2024 09:50
@marco-ippolito

Copy link
Copy Markdown
Member

@nodejs/loaders (I assume this is related to loaders), this update breaks the build

@guybedford

Copy link
Copy Markdown
Contributor

This update was reverted - nodejs/cjs-module-lexer#95.

Unless progress is made on the PR in nodejs/cjs-module-lexer#98, it will be published with the revert.

@marco-ippolitomarco-ippolito added the blocked PRs that are blocked by other issues or PRs. label May 9, 2024
@Pea1594

This comment has been minimized.

@nodejs-github-botnodejs-github-bot changed the title deps: update cjs-module-lexer to 1.3.1deps: update cjs-module-lexer to 1.4.0Sep 1, 2024
@targos

Copy link
Copy Markdown
Member

The build still looks broken.

@targos

Copy link
Copy Markdown
Member
2024-09-01T01:43:13.3207023Z sccache clang++ -o /home/runner/work/node/node/out/Release/node_mksnapshot -pthread -rdynamic -Wl,--whole-archive /home/runner/work/node/node/out/Release/obj.target/deps/zlib/libzlib.a -Wl,--no-whole-archive -Wl,--whole-archive /home/runner/work/node/node/out/Release/obj.target/deps/uv/libuv.a -Wl,--no-whole-archive -Wl,-z,noexecstack -Wl,--whole-archive /home/runner/work/node/node/out/Release/obj.target/tools/v8_gypfiles/libv8_snapshot.a -Wl,--no-whole-archive -Wl,-z,relro -Wl,-z,now -Wl,--whole-archive,/home/runner/work/node/node/out/Release/obj.target/deps/openssl/libopenssl.a -Wl,--no-whole-archive -pthread -m64 -Wl,--start-group /home/runner/work/node/node/out/Release/obj.target/node_mksnapshot/src/node_snapshot_stub.o /home/runner/work/node/node/out/Release/obj.target/node_mksnapshot/tools/snapshot/node_mksnapshot.o /home/runner/work/node/node/out/Release/obj.target/libnode.a /home/runner/work/node/node/out/Release/obj.target/deps/histogram/libhistogram.a /home/runner/work/node/node/out/Release/obj.target/deps/sqlite/libsqlite.a /home/runner/work/node/node/out/Release/obj.target/deps/ada/libada.a /home/runner/work/node/node/out/Release/obj.target/deps/nbytes/libnbytes.a /home/runner/work/node/node/out/Release/obj.target/deps/simdjson/libsimdjson.a /home/runner/work/node/node/out/Release/obj.target/deps/simdutf/libsimdutf.a /home/runner/work/node/node/out/Release/obj.target/deps/ncrypto/libncrypto.a /home/runner/work/node/node/out/Release/obj.target/tools/v8_gypfiles/libv8_snapshot.a /home/runner/work/node/node/out/Release/obj.target/tools/v8_gypfiles/libv8_libplatform.a /home/runner/work/node/node/out/Release/obj.target/tools/icu/libicui18n.a /home/runner/work/node/node/out/Release/obj.target/deps/zlib/libzlib.a /home/runner/work/node/node/out/Release/obj.target/deps/llhttp/libllhttp.a /home/runner/work/node/node/out/Release/obj.target/deps/cares/libcares.a /home/runner/work/node/node/out/Release/obj.target/deps/uv/libuv.a /home/runner/work/node/node/out/Release/obj.target/deps/uvwasi/libuvwasi.a /home/runner/work/node/node/out/Release/obj.target/deps/nghttp2/libnghttp2.a /home/runner/work/node/node/out/Release/obj.target/deps/brotli/libbrotli.a /home/runner/work/node/node/out/Release/obj.target/deps/openssl/libopenssl.a /home/runner/work/node/node/out/Release/obj.target/deps/ngtcp2/libngtcp2.a /home/runner/work/node/node/out/Release/obj.target/deps/ngtcp2/libnghttp3.a /home/runner/work/node/node/out/Release/obj.target/tools/icu/libicuucx.a /home/runner/work/node/node/out/Release/obj.target/tools/icu/libicudata.a /home/runner/work/node/node/out/Release/obj.target/tools/v8_gypfiles/libv8_base_without_compiler.a /home/runner/work/node/node/out/Release/obj.target/tools/v8_gypfiles/libv8_libbase.a /home/runner/work/node/node/out/Release/obj.target/tools/v8_gypfiles/libv8_abseil.a /home/runner/work/node/node/out/Release/obj.target/tools/v8_gypfiles/libv8_zlib.a /home/runner/work/node/node/out/Release/obj.target/tools/v8_gypfiles/libv8_compiler.a /home/runner/work/node/node/out/Release/obj.target/tools/v8_gypfiles/libv8_turboshaft.a /home/runner/work/node/node/out/Release/obj.target/tools/v8_gypfiles/libv8_initializers.a /home/runner/work/node/node/out/Release/obj.target/tools/v8_gypfiles/libv8_initializers_slow.a /home/runner/work/node/node/out/Release/obj.target/deps/zlib/libzlib_inflate_chunk_simd.a /home/runner/work/node/node/out/Release/obj.target/deps/zlib/libzlib_adler32_simd.a -latomic -ldl -lm -Wl,--end-group
2024-09-01T01:43:15.4362881Z LD_LIBRARY_PATH=/home/runner/work/node/node/out/Release/lib.host:/home/runner/work/node/node/out/Release/lib.target:$LD_LIBRARY_PATH; export LD_LIBRARY_PATH; cd ../.; mkdir -p /home/runner/work/node/node/out/Release/obj/gen; "/home/runner/work/node/node/out/Release/node_mksnapshot" "/home/runner/work/node/node/out/Release/obj/gen/node_snapshot.cc"
2024-09-01T01:43:15.4369008Z LD_LIBRARY_PATH=/home/runner/work/node/node/out/Release/lib.host:/home/runner/work/node/node/out/Release/lib.target:$LD_LIBRARY_PATH; export LD_LIBRARY_PATH; cd ../.; mkdir -p /home/runner/work/node/node/out/Release/obj.target/deps/openssl; /opt/hostedtoolcache/Python/3.12.5/x64/bin/python3 tools/copyfile.py ./deps/openssl/nodejs-openssl.cnf "/home/runner/work/node/node/out/Release/obj.target/deps/openssl/openssl.cnf"
2024-09-01T01:43:15.5765865Z node:internal/deps/cjs-module-lexer/lexer:1444
2024-09-01T01:43:15.5766765Z 2024-09-01T01:43:15.5766788Z 2024-09-01T01:43:15.5767358Z 2024-09-01T01:43:15.5767696Z SyntaxError: Invalid or unexpected token
2024-09-01T01:43:15.5768229Z 2024-09-01T01:43:15.6577858Z make[2]: *** [node.target.mk:13: /home/runner/work/node/node/out/Release/obj/gen/node_snapshot.cc] Error 1

@guybedford

Copy link
Copy Markdown
Contributor

I just cloned this branch, built and tested locally, and all seems to be working fine to me. Let me know if I can assist further.

@targos

Copy link
Copy Markdown
Member

Let's try to recreate from scratch

@targostargos closed this Sep 2, 2024
@targos
targos deleted the actions/tools-update-cjs-module-lexer branch September 2, 2024 05:41
@targos

Copy link
Copy Markdown
Member

#54713

@guybedford

Copy link
Copy Markdown
Contributor

Thanks @targos I'm building and testing on Windows so it seems like it's working fine on Windows. I can try a build on my work machine tomorrow if it helps.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blockedPRs that are blocked by other issues or PRs.dependenciesPull requests that update a dependency file.lib / srcIssues and PRs related to general changes in the lib or src directory.needs-ciPRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@nodejs-github-bot@marco-ippolito@guybedford@Pea1594@targos