Skip to content

perf_hooks: implement performance.now() with fast API calls - #50492

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
joyeecheung:fast-now
Nov 17, 2023
Merged

perf_hooks: implement performance.now() with fast API calls#50492
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
joyeecheung:fast-now

Conversation

@joyeecheung

@joyeecheungjoyeecheung commented Oct 31, 2023

Copy link
Copy Markdown
Member

Local benchmark numbers:

 confidence improvement accuracy (*) (**) (***)
perf_hooks/now.js n=1000000 *** 7.04 % ±1.38% ±1.84% ±2.40%

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Oct 31, 2023
@joyeecheungjoyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 31, 2023
@H4adH4ad added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 31, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 31, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 31, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55358/

@nodejs-github-bot

nodejs-github-bot commented Oct 31, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55372/

@github-actionsgithub-actionsBot mentioned this pull request Nov 1, 2023
Open
24 tasks
@devsnek

devsnek commented Nov 1, 2023

Copy link
Copy Markdown
Member

I haven't kept up with fast calls lately but originally the double return type was only supported on some architectures. Do we know that this is actually optimizing the call everywhere?

@joyeecheung

joyeecheung commented Nov 1, 2023

Copy link
Copy Markdown
MemberAuthor

Haven’t really looked into if it’s always optimized but I think fast APIs are not guaranteed to always be hit anyway, that’s why the slow fallback callbacks are required.

legendecas
legendecas reviewed Nov 1, 2023
View reviewed changes
Comment threadsrc/node_perf.cc
@devsnek

devsnek commented Nov 1, 2023

Copy link
Copy Markdown
Member

@joyeecheung i think my only concern would be whether this was, in practice, a regression on any of our supported platforms. maybe a benchmark run could double check?

This was referenced Nov 2, 2023
Open
Open
@joyeecheung

joyeecheung commented Nov 3, 2023•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

We only have benchmark CI on Ubuntu x64 but here is a CI run https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1469/

i think my only concern would be whether this was, in practice, a regression on any of our supported platforms. maybe a benchmark run could double check?

JSCallReducer should just skip generating fast calls for signatures that are not supported on the running platform, that's why the slow callback is required. If a regression can be caused by running a fast call on a platform it cannot optimize, that sounds more like an internal bug of V8...

@joyeecheung

joyeecheung commented Nov 3, 2023

Copy link
Copy Markdown
MemberAuthor

From benchmark CI:

10:04:57 confidence improvement accuracy (*) (**) (***)
10:04:57 perf_hooks/now.js n=1000000 ** 12.90 % ±8.03% ±10.75% ±14.13%

@joyeecheungjoyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 3, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 3, 2023
@nodejs-github-bot

nodejs-github-bot commented Nov 3, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55440/

H4ad
H4ad approved these changes Nov 3, 2023
View reviewed changes
@github-actionsgithub-actionsBot mentioned this pull request Nov 4, 2023
Open
14 tasks
@nodejs-github-bot

nodejs-github-bot commented Nov 4, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55444/

This was referenced Nov 5, 2023
Open
Open
@nodejs-github-bot

nodejs-github-bot commented Nov 6, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55458/

@github-actionsgithub-actionsBot mentioned this pull request Nov 7, 2023
Open
16 tasks
@nodejs-github-bot

nodejs-github-bot commented Nov 7, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55471/

This was referenced Nov 8, 2023
Open
Open
Open
Open
@joyeecheungjoyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 14, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 14, 2023
@nodejs-github-bot

nodejs-github-bot commented Nov 14, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55648/

@github-actionsgithub-actionsBot mentioned this pull request Nov 15, 2023
Open
26 tasks
@nodejs-github-bot

nodejs-github-bot commented Nov 15, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55659/

@nodejs-github-bot

nodejs-github-bot commented Nov 15, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55666/

@nodejs-github-bot

nodejs-github-bot commented Nov 17, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55726/

@H4adH4ad added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 17, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 17, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 8c7fe47 into nodejs:mainNov 17, 2023
@nodejs-github-bot

nodejs-github-bot commented Nov 17, 2023

Copy link
Copy Markdown
Collaborator

Landed in 8c7fe47

targos pushed a commit that referenced this pull request Nov 23, 2023
@joyeecheung@targos
perf_hooks: implement performance.now() with fast API calls
a9031e7
PR-URL: #50492
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
lucshi pushed a commit to lucshi/node that referenced this pull request Nov 27, 2023
@joyeecheungLei Shi
perf_hooks: implement performance.now() with fast API calls
dfde215
PR-URL: nodejs#50492
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
@RafaelGSSRafaelGSS mentioned this pull request Nov 28, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 29, 2023
@joyeecheung@RafaelGSS
perf_hooks: implement performance.now() with fast API calls
aebe2fc
PR-URL: #50492
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@joyeecheung@UlisesGascon
perf_hooks: implement performance.now() with fast API calls
2cf5bda
PR-URL: #50492
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
@UlisesGasconUlisesGascon mentioned this pull request Dec 12, 2023
Merged
UlisesGascon pushed a commit that referenced this pull request Dec 19, 2023
@joyeecheung@UlisesGascon
perf_hooks: implement performance.now() with fast API calls
a7d8f6b
PR-URL: #50492
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benglbenglbengl approved these changes
@QardQardQard approved these changes
@benjamingrbenjamingrbenjamingr approved these changes
@anonriganonriganonrig approved these changes
@legendecaslegendecaslegendecas approved these changes
@H4adH4adH4ad approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@joyeecheung@nodejs-github-bot@devsnek@bengl@Qard@benjamingr@anonrig@legendecas@H4ad