Skip to content

test: relax version check with shared OpenSSL - #50505

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
lpinca:relax/openssl-version-check
Nov 8, 2023
Merged

test: relax version check with shared OpenSSL#50505
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
lpinca:relax/openssl-version-check

Conversation

@lpinca

@lpincalpinca commented Nov 1, 2023

Copy link
Copy Markdown
Member

Relax the OpenSSL version check when Node.js is built with the --shared-openssl option. Verify only that process.versions.openssl is truthy.

Fixes: #43078

@lpinca
test: relax version check with shared OpenSSL
8738a7f
Relax the OpenSSL version check when Node.js is built with the
`--shared-openssl` option. Verify only that `process.versions.openssl`
is truthy.
Fixes: nodejs#43078
@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 1, 2023
@lpincalpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 1, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 1, 2023
@nodejs-github-bot

nodejs-github-bot commented Nov 1, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55389/

@github-actionsgithub-actionsBot mentioned this pull request Nov 2, 2023
Open
25 tasks
@nodejs-github-bot

nodejs-github-bot commented Nov 2, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55406/

@nodejs-github-bot

nodejs-github-bot commented Nov 2, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55417/

This was referenced Nov 3, 2023
Open
Open
Open
Open
Open
Open
@lpincalpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 8, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 8, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 3e3467e into nodejs:mainNov 8, 2023
@nodejs-github-bot

nodejs-github-bot commented Nov 8, 2023

Copy link
Copy Markdown
Collaborator

Landed in 3e3467e

@lpinca
lpinca deleted the relax/openssl-version-check branch November 8, 2023 20:59
targos pushed a commit that referenced this pull request Nov 11, 2023
@lpinca@targos
test: relax version check with shared OpenSSL
6005672
Relax the OpenSSL version check when Node.js is built with the
`--shared-openssl` option. Verify only that `process.versions.openssl`
is truthy.
Fixes: #43078
PR-URL: #50505
Reviewed-By: Richard Lau <rlau@redhat.com>
@targostargos mentioned this pull request Nov 12, 2023
Merged
targos pushed a commit that referenced this pull request Nov 14, 2023
@lpinca@targos
test: relax version check with shared OpenSSL
931e1e7
Relax the OpenSSL version check when Node.js is built with the
`--shared-openssl` option. Verify only that `process.versions.openssl`
is truthy.
Fixes: #43078
PR-URL: #50505
Reviewed-By: Richard Lau <rlau@redhat.com>
targos pushed a commit that referenced this pull request Nov 15, 2023
@lpinca@targos
test: relax version check with shared OpenSSL
4e34f9a
Relax the OpenSSL version check when Node.js is built with the
`--shared-openssl` option. Verify only that `process.versions.openssl`
is truthy.
Fixes: #43078
PR-URL: #50505
Reviewed-By: Richard Lau <rlau@redhat.com>
targos pushed a commit that referenced this pull request Nov 15, 2023
@lpinca@targos
test: relax version check with shared OpenSSL
8c918e5
Relax the OpenSSL version check when Node.js is built with the
`--shared-openssl` option. Verify only that `process.versions.openssl`
is truthy.
Fixes: #43078
PR-URL: #50505
Reviewed-By: Richard Lau <rlau@redhat.com>
@targostargos mentioned this pull request Nov 21, 2023
Merged
@targostargos mentioned this pull request Nov 28, 2023
Merged
@juanarboljuanarbol mentioned this pull request Dec 6, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test: relax version check with shared OpenSSL
2daf5a8
Relax the OpenSSL version check when Node.js is built with the
`--shared-openssl` option. Verify only that `process.versions.openssl`
is truthy.
Fixes: nodejs/node#43078
PR-URL: nodejs/node#50505
Reviewed-By: Richard Lau <rlau@redhat.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test: relax version check with shared OpenSSL
fb7058b
Relax the OpenSSL version check when Node.js is built with the
`--shared-openssl` option. Verify only that `process.versions.openssl`
is truthy.
Fixes: nodejs/node#43078
PR-URL: nodejs/node#50505
Reviewed-By: Richard Lau <rlau@redhat.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardlaurichardlaurichardlau approved these changes

Assignees

No one assigned

Labels

needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

FreeBSD openssl version string doesn't match regex test

4 participants

@lpinca@nodejs-github-bot@richardlau@targos