Uh oh!
There was an error while loading. Please reload this page.
src: use v8::Isolate::TryGetCurrent() in DumpJavaScriptBacktrace() - #50518
Closed
joyeecheung wants to merge 3 commits into
Closed
src: use v8::Isolate::TryGetCurrent() in DumpJavaScriptBacktrace()#50518joyeecheung wants to merge 3 commits into
joyeecheung wants to merge 3 commits into
Conversation
It was using Isolate::GetCurrent() which DCHECK on nullptr, even though what we wanted was to return early if it is nullptr.
H4ad
approved these changes
Nov 2, 2023
nodejs-github-bot
commented
Nov 2, 2023
Collaborator
nodejs-github-bot
commented
Nov 2, 2023
Collaborator
legendecas
left a comment
Member
There was a problem hiding this comment.
Might be worth adding a cctest to verify DumpJavaScriptBacktrace won't trigger DCHECK when no isolate is entered?
22 tasks
MemberAuthor
Added a cctest |
nodejs-github-bot
commented
Nov 3, 2023
Collaborator
H4ad
approved these changes
Nov 3, 2023
legendecas
approved these changes
Nov 3, 2023
14 tasks
nodejs-github-bot
commented
Nov 4, 2023
Collaborator
This was referenced Nov 5, 2023
joyeecheung
commented
Nov 6, 2023
MemberAuthor
Landed in 036c89f with the linter issue fixed. |
joyeecheung added a commit
that referenced
this pull request
Nov 6, 2023
It was using Isolate::GetCurrent() which DCHECK on nullptr, even though what we wanted was to return early if it is nullptr. PR-URL: #50518 Refs: #50242 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
This was referenced Nov 7, 2023
targos pushed a commit
that referenced
this pull request
Nov 11, 2023
It was using Isolate::GetCurrent() which DCHECK on nullptr, even though what we wanted was to return early if it is nullptr. PR-URL: #50518 Refs: #50242 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
targos pushed a commit
that referenced
this pull request
Nov 14, 2023
It was using Isolate::GetCurrent() which DCHECK on nullptr, even though what we wanted was to return early if it is nullptr. PR-URL: #50518 Refs: #50242 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
UlisesGascon pushed a commit
that referenced
this pull request
Dec 11, 2023
It was using Isolate::GetCurrent() which DCHECK on nullptr, even though what we wanted was to return early if it is nullptr. PR-URL: #50518 Refs: #50242 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was using Isolate::GetCurrent() which DCHECK on nullptr, even though what we wanted was to return early if it is nullptr.
Refs: #50242