Uh oh!
There was an error while loading. Please reload this page.
test: remove unused file - #50528
Merged
Merged
Conversation
jsumnersforce-pushed
the
remove-unused-file
branch
from
November 2, 2023 13:10
fb62571 to
907393eComparelpinca
approved these changes
Nov 2, 2023
legendecas
approved these changes
Nov 2, 2023
nodejs-github-bot
commented
Nov 3, 2023
Collaborator
tniessen
approved these changes
Nov 3, 2023
tniessen
left a comment
Member
There was a problem hiding this comment.
Please fix before merging: the subsystem in the commit message is wrong. It should likely be test, not src.
This removes a source file that got re-added via a rebase. It seems somewhere around change set nodejs@178dff2 `entry_point.c` was removed, and rebase nodejs@0b6e16f added it back. The review of nodejs#48740 overlooked this and the file got re-committed.
jsumnersforce-pushed
the
remove-unused-file
branch
from
November 3, 2023 16:50
907393e to
69ae652Comparenodejs-github-bot
commented
Nov 3, 2023
Collaborator
nodejs-github-bot
commented
Nov 10, 2023
Collaborator
Member
https://ci.nodejs.org/job/node-test-commit-aix/48935/ was failing for |
legendecas
approved these changes
Nov 10, 2023
nodejs-github-bot
commented
Nov 10, 2023
Collaborator
Landed in 43f5b22 |
targos pushed a commit
that referenced
this pull request
Nov 11, 2023
This removes a source file that got re-added via a rebase. It seems somewhere around change set 178dff2 `entry_point.c` was removed, and rebase 0b6e16f added it back. The review of #48740 overlooked this and the file got re-committed. PR-URL: #50528 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Vladimir Morozov <vmorozov@microsoft.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos pushed a commit
that referenced
this pull request
Nov 14, 2023
This removes a source file that got re-added via a rebase. It seems somewhere around change set 178dff2 `entry_point.c` was removed, and rebase 0b6e16f added it back. The review of #48740 overlooked this and the file got re-committed. PR-URL: #50528 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Vladimir Morozov <vmorozov@microsoft.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
UlisesGascon pushed a commit
that referenced
this pull request
Dec 11, 2023
This removes a source file that got re-added via a rebase. It seems somewhere around change set 178dff2 `entry_point.c` was removed, and rebase 0b6e16f added it back. The review of #48740 overlooked this and the file got re-committed. PR-URL: #50528 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Vladimir Morozov <vmorozov@microsoft.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes a source file that got re-added via a rebase. It seems somewhere around change set
178dff2
entry_point.cwas removed, and rebase0b6e16f added it back. The review of #48740 overlooked this and the file got re-committed.