Uh oh!
There was an error while loading. Please reload this page.
build: fix build with Python 3.12 - #50582
Merged
Merged
Conversation
lpincaforce-pushed
the
fix/build-with-python-3-12
branch
from
November 6, 2023 20:09
66e9326 to
676e9b4Comparenodejs-github-bot
commented
Nov 6, 2023
Collaborator
Replace `distutils.version.StrictVersion` with `packaging.version.Version`. Refs: nodejs#50209 (comment)
lpincaforce-pushed
the
fix/build-with-python-3-12
branch
from
November 7, 2023 07:33
676e9b4 to
7ce12adComparenodejs-github-bot
commented
Nov 7, 2023
Collaborator
nodejs-github-bot
commented
Nov 7, 2023
Collaborator
richardlau
approved these changes
Nov 7, 2023
richardlau
commented
Nov 7, 2023
Member
legendecas
commented
Nov 7, 2023
Member
Can we fast-track this? |
Contributor
Fast-track has been requested by @lpinca. Please 👍 to approve. |
legendecas
approved these changes
Nov 7, 2023
16 tasks
nodejs-github-bot
commented
Nov 8, 2023
Collaborator
Landed in 95534ad |
This was referenced Nov 9, 2023
targos pushed a commit
that referenced
this pull request
Nov 11, 2023
Replace `distutils.version.StrictVersion` with `packaging.version.Version`. Refs: #50209 (comment) PR-URL: #50582 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
targos pushed a commit
that referenced
this pull request
Nov 14, 2023
Replace `distutils.version.StrictVersion` with `packaging.version.Version`. Refs: #50209 (comment) PR-URL: #50582 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
UlisesGascon pushed a commit
that referenced
this pull request
Dec 11, 2023
Replace `distutils.version.StrictVersion` with `packaging.version.Version`. Refs: #50209 (comment) PR-URL: #50582 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Merged
joshuafried pushed a commit
to joshuafried/node
that referenced
this pull request
Sep 13, 2024
Replace `distutils.version.StrictVersion` with `packaging.version.Version`. Refs: nodejs/node#50209 (comment) PR-URL: nodejs/node#50582 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Nov 2, 2024
Replace `distutils.version.StrictVersion` with `packaging.version.Version`. Refs: #50209 (comment) PR-URL: #50582 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
distutils.version.StrictVersionwithpackaging.version.Version.