test: replace forEach with for of by RBrNx · Pull Request #50594 · nodejs/node

Hey @RafaelGSS @marco-ippolito @lpinca @jasnell, I noticed that some of the checks seem to be consistently failing for this PR - is there an issue with the code or is it a CI issue preventing the checks from passing?

nodejs-github-bot · 2023-11-21T12:49:52Z

CI: https://ci.nodejs.org/job/node-test-pull-request/55821/

RafaelGSS · 2023-11-21T21:08:37Z

Hey @RafaelGSS @marco-ippolito @lpinca @jasnell, I noticed that some of the checks seem to be consistently failing for this PR - is there an issue with the code or is it a CI issue preventing the checks from passing?

I suspect this should be fixed on main. Would you mind rebasing this pr?

RBrNx · 2023-11-22T11:08:09Z

Hey @RafaelGSS, rebased and pushed! Hopefully the CI checks pass this time 😄

nodejs-github-bot · 2023-11-22T12:52:54Z

CI: https://ci.nodejs.org/job/node-test-pull-request/55853/

nodejs-github-bot · 2023-11-24T14:00:45Z

Commit Queue failed

- Loading data for nodejs/node/pull/50594
✔ Done loading data for nodejs/node/pull/50594
----------------------------------- PR info ------------------------------------
Title test: replace forEach with for of (#50594)
Author Conor Watson (@RBrNx, first-time contributor)
Branch RBrNx:nodeconfeu-first-contrib -> nodejs:main
Labels test, code-and-learn, needs-ci, commit-queue-squash
Commits 2
- test: replace forEach with for of
- fixup! test: replace forEach with for of
Committers 1
- RBrNx PR-URL: https://github.com/nodejs/node/pull/50594
Reviewed-By: Rafael Gonzaga Reviewed-By: Marco Ippolito Reviewed-By: Luigi Pinca Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/50594
Reviewed-By: Rafael Gonzaga Reviewed-By: Marco Ippolito Reviewed-By: Luigi Pinca Reviewed-By: James M Snell --------------------------------------------------------------------------------
⚠ Commits were pushed since the last approving review:
⚠ - test: replace forEach with for of
⚠ - fixup! test: replace forEach with for of
ℹ This PR was created on Tue, 07 Nov 2023 14:59:07 GMT
✔ Approvals: 4
✔ - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/50594#pullrequestreview-1717930171
✔ - Marco Ippolito (@marco-ippolito): https://github.com/nodejs/node/pull/50594#pullrequestreview-1717957296
✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/50594#pullrequestreview-1718803041
✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/50594#pullrequestreview-1726071964
ℹ This PR is being fast-tracked because it is from a Code and Learn event
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2023-11-22T12:52:54Z: https://ci.nodejs.org/job/node-test-pull-request/55853/
- Querying data for job/node-test-pull-request/55853/
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/6981633672

nodejs-github-bot · 2023-11-24T14:11:36Z

Landed in 303654c

PR-URL: nodejs#50594 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: #50594 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 7, 2023

RafaelGSS added code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 7, 2023

RafaelGSS approved these changes Nov 7, 2023
View reviewed changes

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 7, 2023

RafaelGSS added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Nov 7, 2023

RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 7, 2023

marco-ippolito approved these changes Nov 7, 2023
View reviewed changes

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 7, 2023

lpinca approved these changes Nov 7, 2023
View reviewed changes

github-actionsBot mentioned this pull request Nov 8, 2023
CI Reliability 2023-11-08 nodejs/reliability#711
Open
16 tasks

github-actionsBot mentioned this pull request Nov 9, 2023
CI Reliability 2023-11-09 nodejs/reliability#712
Open
20 tasks

github-actionsBot mentioned this pull request Nov 10, 2023
CI Reliability 2023-11-10 nodejs/reliability#713
Open
18 tasks

github-actionsBot mentioned this pull request Nov 11, 2023
CI Reliability 2023-11-11 nodejs/reliability#714
Open
27 tasks

This comment was marked as outdated.
Sign in to view

jasnell approved these changes Nov 11, 2023
View reviewed changes

This was referenced Nov 12, 2023
CI Reliability 2023-11-12 nodejs/reliability#715
Open
CI Reliability 2023-11-13 nodejs/reliability#716
Open
CI Reliability 2023-11-14 nodejs/reliability#717
Open
CI Reliability 2023-11-15 nodejs/reliability#718
Open

RBrNx added 2 commits November 22, 2023 11:06

test: replace forEach with for of
9e60471

fixup! test: replace forEach with for of
0b856ff

RBrNx force-pushed the nodeconfeu-first-contrib branch from af00890 to 0b856ffCompare November 22, 2023 11:07

RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 22, 2023

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 22, 2023

RafaelGSS added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 24, 2023

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 24, 2023

RafaelGSS approved these changes Nov 24, 2023
View reviewed changes

RafaelGSS added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Nov 24, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 24, 2023

nodejs-github-bot merged commit 303654c into nodejs:mainNov 24, 2023

RafaelGSS mentioned this pull request Nov 28, 2023
v21.3.0 proposal #50954
Merged

UlisesGascon mentioned this pull request Dec 12, 2023
v20.11.0 proposal #51124
Merged

Uh oh!

Uh oh!

Conversation

RBrNx commented Nov 7, 2023

Uh oh!

RafaelGSS left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Nov 7, 2023

Uh oh!

nodejs-github-bot commented Nov 7, 2023

Uh oh!

nodejs-github-bot commented Nov 7, 2023

Uh oh!

nodejs-github-bot commented Nov 8, 2023

Uh oh!

nodejs-github-bot commented Nov 9, 2023

Uh oh!

nodejs-github-bot commented Nov 10, 2023

Uh oh!

nodejs-github-bot commented Nov 10, 2023

Uh oh!

This comment was marked as outdated.

nodejs-github-bot commented Nov 11, 2023

Uh oh!

RBrNx commented Nov 15, 2023

Uh oh!

nodejs-github-bot commented Nov 21, 2023

Uh oh!

RafaelGSS commented Nov 21, 2023

Uh oh!

RBrNx commented Nov 22, 2023

Uh oh!

nodejs-github-bot commented Nov 22, 2023

Uh oh!

nodejs-github-bot commented Nov 24, 2023

Uh oh!

nodejs-github-bot commented Nov 24, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants