Skip to content

test: replace foreach with for - #50599

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
bluescreen:main
Nov 15, 2023
Merged

test: replace foreach with for#50599
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
bluescreen:main

Conversation

@bluescreen

@bluescreenbluescreen commented Nov 7, 2023

Copy link
Copy Markdown
Contributor

nodeconf 2023

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 7, 2023
@marco-ippolitomarco-ippolito added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 7, 2023
@lpinca

lpinca commented Nov 8, 2023

Copy link
Copy Markdown
Member

Can you please revert unrelated changes?

@bluescreen

bluescreen commented Nov 13, 2023

Copy link
Copy Markdown
ContributorAuthor

Can you please revert unrelated changes?

Done

@lpincalpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 13, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 13, 2023
@nodejs-github-bot

nodejs-github-bot commented Nov 13, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55610/

@bluescreen

bluescreen commented Nov 13, 2023

Copy link
Copy Markdown
ContributorAuthor

@lpinca what happened? Looks like the merge is still blocked. Just trying to understand how nodejs CI system actually works.

@lpinca

lpinca commented Nov 13, 2023

Copy link
Copy Markdown
Member

Unrelated CI failure.

@lpinca

lpinca commented Nov 13, 2023•
edited
Loading

Copy link
Copy Markdown
Member

@bluescreen can you please also change "replaced" to "replace" in the commit message? We can do that before landing but it would be easier if you do it as we can simply apply the "commit-queue" label and get the PR merged automatically in that case. Thank you.

@bluescreen

bluescreen commented Nov 13, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@bluescreen can you please also change "replaced" to "replace" in the commit message? We can do that before landing but it would be easier if you do it as we can simply apply the "commit-queue" label and get the PR merged automatically in that case. Thank you.

I squashed the commits and changed the message. Now only the relevant changes made on nodeconf should be in the PR. Hope it's fine for a first learning contribution in nodejs. :)

@github-actionsgithub-actionsBot mentioned this pull request Nov 14, 2023
Open
25 tasks
@lpincalpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 14, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 14, 2023
@nodejs-github-bot

nodejs-github-bot commented Nov 14, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55630/

@bluescreen

bluescreen commented Nov 14, 2023

Copy link
Copy Markdown
ContributorAuthor

@lpinca what went wrong?

@nodejs-github-bot

nodejs-github-bot commented Nov 14, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55646/

@github-actionsgithub-actionsBot mentioned this pull request Nov 15, 2023
Open
26 tasks
@bluescreen

bluescreen commented Nov 15, 2023

Copy link
Copy Markdown
ContributorAuthor

Wohoo it worked! All checks passed. Ready to merge :)

@tniessentniessen changed the title test: replaced foreach with for-looptest: replace foreach with forNov 15, 2023
@tniessentniessen added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 15, 2023
@tniessen

tniessen commented Nov 15, 2023

Copy link
Copy Markdown
Member

Thank you @bluescreen!

@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 15, 2023
@nodejs-github-bot
nodejs-github-bot merged commit ff879cd into nodejs:mainNov 15, 2023
@nodejs-github-bot

nodejs-github-bot commented Nov 15, 2023

Copy link
Copy Markdown
Collaborator

Landed in ff879cd

targos pushed a commit that referenced this pull request Nov 23, 2023
@bluescreen@targos
test: replace foreach with for
0e8275b
PR-URL: #50599
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@RafaelGSSRafaelGSS mentioned this pull request Nov 28, 2023
Merged
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@bluescreen@UlisesGascon
test: replace foreach with for
37f3ebc
PR-URL: #50599
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@UlisesGasconUlisesGascon mentioned this pull request Dec 12, 2023
Merged
UlisesGascon pushed a commit that referenced this pull request Dec 19, 2023
@bluescreen@UlisesGascon
test: replace foreach with for
5712c41
PR-URL: #50599
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@tniessentniessentniessen approved these changes

Assignees

No one assigned

Labels

code-and-learnIssues related to the Code-and-Learn events and PRs submitted during the events.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bluescreen@lpinca@nodejs-github-bot@tniessen@marco-ippolito