Skip to content

test: Replace forEach() with for ... of in test-assert-typedarray-deepequal.js - #50610

Closed
JJJ54321 wants to merge 6 commits into
nodejs:mainfrom
JJJ54321:main
Closed

test: Replace forEach() with for ... of in test-assert-typedarray-deepequal.js#50610
JJJ54321 wants to merge 6 commits into
nodejs:mainfrom
JJJ54321:main

Conversation

@JJJ54321

@JJJ54321JJJ54321 commented Nov 7, 2023

Copy link
Copy Markdown
Contributor

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 7, 2023
@tniessen

tniessen commented Nov 7, 2023

Copy link
Copy Markdown
Member

@jialiu54321 Thank you for the contribution. The commit message does not match the commit message guidelines. It needs to start with the prefix test:, followed by a space and an imperative lowercase verb. The length must not exceed 70 characters.

@tniessentniessen added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 7, 2023
@JJJ54321JJJ54321 changed the title Replace forEach() with for ... of and use destructuring in test-assert-typedarray-deepequal.jstest: Replace forEach() with for ... of in test-assert-typedarray-deepequal.jsNov 7, 2023
lpinca
lpinca reviewed Dec 27, 2023
View reviewed changes
Comment threadtest/parallel/test-assert-typedarray-deepequal.js Outdated
Comment threadtest/parallel/test-assert-typedarray-deepequal.js Outdated
@lpincalpinca added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. request-ci Add this label to start a Jenkins CI on a PR. labels Dec 27, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 27, 2023
@nodejs-github-bot

nodejs-github-bot commented Dec 27, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56549/

lpinca
lpinca reviewed Dec 27, 2023
View reviewed changes
Comment threadtest/parallel/test-assert-typedarray-deepequal.js Outdated
Comment threadtest/parallel/test-assert-typedarray-deepequal.js Outdated
Comment threadtest/parallel/test-assert-typedarray-deepequal.js Outdated
@lpincalpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 27, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 27, 2023
@nodejs-github-bot

nodejs-github-bot commented Dec 27, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56566/

lpinca pushed a commit that referenced this pull request Dec 28, 2023
@JJJ54321@lpinca
test: replace forEach() with for...of
4560834
Replace `forEach()` with `for...of` in
`test/parallel/test-assert-typedarray-deepequal.js`.
PR-URL: #50610
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@lpinca

lpinca commented Dec 28, 2023

Copy link
Copy Markdown
Member

Landed in 4560834.

@lpincalpinca closed this Dec 28, 2023
RafaelGSS pushed a commit that referenced this pull request Jan 2, 2024
@JJJ54321@RafaelGSS
test: replace forEach() with for...of
652af45
Replace `forEach()` with `for...of` in
`test/parallel/test-assert-typedarray-deepequal.js`.
PR-URL: #50610
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request Jan 2, 2024
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@JJJ54321@richardlau
test: replace forEach() with for...of
42b162b
Replace `forEach()` with `for...of` in
`test/parallel/test-assert-typedarray-deepequal.js`.
PR-URL: #50610
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@richardlaurichardlau mentioned this pull request Mar 25, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes

Assignees

No one assigned

Labels

code-and-learnIssues related to the Code-and-Learn events and PRs submitted during the events.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JJJ54321@tniessen@nodejs-github-bot@lpinca