Skip to content

test: replace forEach with for...of - #50611

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
SpaceDux:nodeconfeu-rep-fE
Nov 12, 2023
Merged

test: replace forEach with for...of#50611
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
SpaceDux:nodeconfeu-rep-fE

Conversation

@SpaceDux

@SpaceDuxSpaceDux commented Nov 7, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 7, 2023
@tniessen

tniessen commented Nov 7, 2023

Copy link
Copy Markdown
Member

Thanks for the contribution @SpaceDux. Unfortunately, the commit message does not match our commit message guidelines. I'd suggest test: replace forEach with for...of or something similar. If you'd like, we can make this change for you by force-pushing to your branch.

@tniessentniessen added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 7, 2023
@SpaceDuxSpaceDux changed the title test: Replace .forEach with for...consttest: replace forEach with for...ofNov 7, 2023
@SpaceDux

SpaceDux commented Nov 7, 2023

Copy link
Copy Markdown
ContributorAuthor

Thanks for the contribution @SpaceDux. Unfortunately, the commit message does not match our commit message guidelines. I'd suggest test: replace forEach with for...of or something similar. If you'd like, we can make this change for you by force-pushing to your branch.

Thanks for the heads up. I have corrected the commit message now, hopefully its all good?.

tniessen
tniessen approved these changes Nov 8, 2023
View reviewed changes

@tniessentniessen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you @SpaceDux!

@tniessentniessen added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 8, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 8, 2023
@nodejs-github-bot

nodejs-github-bot commented Nov 8, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55500/

@nodejs-github-bot

nodejs-github-bot commented Nov 11, 2023•
edited by jasnell
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55578/ 💛

@jasnelljasnell added commit-queue Add this label to land a pull request using GitHub Actions. and removed needs-ci PRs that need a full CI run. labels Nov 12, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 12, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 242cbd7 into nodejs:mainNov 12, 2023
@nodejs-github-bot

nodejs-github-bot commented Nov 12, 2023

Copy link
Copy Markdown
Collaborator

Landed in 242cbd7

targos pushed a commit that referenced this pull request Nov 23, 2023
@SpaceDux@targos
test: replace forEach with for...of
75265e4
PR-URL: #50611
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request Nov 28, 2023
Merged
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@SpaceDux@UlisesGascon
test: replace forEach with for...of
4d28ced
PR-URL: #50611
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@UlisesGasconUlisesGascon mentioned this pull request Dec 12, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@tniessentniessentniessen approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.code-and-learnIssues related to the Code-and-Learn events and PRs submitted during the events.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@SpaceDux@tniessen@nodejs-github-bot@lpinca@jasnell