Skip to content

test: replace forEach with for [...] of - #50615

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
dygabo:nodeconf_workshop
Nov 10, 2023
Merged

test: replace forEach with for [...] of#50615
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
dygabo:nodeconf_workshop

Conversation

@dygabo

@dygabodygabo commented Nov 7, 2023

Copy link
Copy Markdown
Member

NodeConf EU Workshop

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 7, 2023
tniessen
tniessen approved these changes Nov 8, 2023
View reviewed changes

@tniessentniessen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @dygabo!

@tniessentniessen added code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 8, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 8, 2023
@nodejs-github-bot

nodejs-github-bot commented Nov 8, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55499/

@debadree25debadree25 added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 10, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 10, 2023
@nodejs-github-bot
nodejs-github-bot merged commit f662c9b into nodejs:mainNov 10, 2023
@nodejs-github-bot

nodejs-github-bot commented Nov 10, 2023

Copy link
Copy Markdown
Collaborator

Landed in f662c9b

targos pushed a commit that referenced this pull request Nov 11, 2023
@dygabo@targos
test: replace forEach with for [...] of
924b331
PR-URL: #50615
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
@targostargos mentioned this pull request Nov 12, 2023
Merged
targos pushed a commit that referenced this pull request Nov 14, 2023
@dygabo@targos
test: replace forEach with for [...] of
52b517f
PR-URL: #50615
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@dygabo@UlisesGascon
test: replace forEach with for [...] of
ea61261
PR-URL: #50615
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
@UlisesGasconUlisesGascon mentioned this pull request Dec 12, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tniessentniessentniessen approved these changes
+1 more reviewer
@debadree25debadree25debadree25 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.code-and-learnIssues related to the Code-and-Learn events and PRs submitted during the events.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dygabo@nodejs-github-bot@tniessen@debadree25