Skip to content

tools: remove unused file for OSX Notarization - #50622

Closed
UlisesGascon wants to merge 1 commit into
nodejs:mainfrom
UlisesGascon:tools/osx-remove-file
Closed

tools: remove unused file for OSX Notarization#50622
UlisesGascon wants to merge 1 commit into
nodejs:mainfrom
UlisesGascon:tools/osx-remove-file

Conversation

@UlisesGascon

@UlisesGasconUlisesGascon commented Nov 8, 2023•
edited
Loading

Copy link
Copy Markdown
Member

The file tools/osx-gon-config.json.tmpl was in use until e97d256.

We drop support for Gon already in #50291

cc: @nodejs/build @nodejs/releasers

@nodejs-github-botnodejs-github-bot added macos Issues and PRs related to the macOS platform / OSX. tools Issues and PRs related to the tools directory. labels Nov 8, 2023
@UlisesGascon
UlisesGascon marked this pull request as ready for review November 8, 2023 10:04
mhdawson
mhdawson approved these changes Nov 14, 2023
View reviewed changes

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mhdawson pushed a commit that referenced this pull request Nov 14, 2023
@UlisesGascon@mhdawson
tools: remove unused file
dfbca33
PR-URL: #50622
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@mhdawson

mhdawson commented Nov 14, 2023

Copy link
Copy Markdown
Member

Landed in dfbca33

targos pushed a commit that referenced this pull request Nov 23, 2023
@UlisesGascon@targos
tools: remove unused file
5ef6729
PR-URL: #50622
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@RafaelGSSRafaelGSS mentioned this pull request Nov 28, 2023
Merged
UlisesGascon added a commit that referenced this pull request Dec 11, 2023
@UlisesGascon
tools: remove unused file
144431b
PR-URL: #50622
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@UlisesGasconUlisesGascon mentioned this pull request Dec 12, 2023
Merged
UlisesGascon added a commit that referenced this pull request Dec 19, 2023
@UlisesGascon
tools: remove unused file
2a451e1
PR-URL: #50622
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
richardlau pushed a commit that referenced this pull request Jan 16, 2024
@UlisesGascon@richardlau
tools: remove unused file
f4b0706
PR-URL: #50622
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
RafaelGSS pushed a commit that referenced this pull request Feb 14, 2024
@marco-ippolito@RafaelGSS
2024-02-14, Version 18.19.1 'Hydrogen' (LTS)
2a5a150
This is a security release.
Notable changes:
crypto:
* update root certificates to NSS 3.95 (Node.js GitHub Bot) #50805
* disable PKCS#1 padding for privateDecrypt (Michael Dawson) nodejs-private/node-private#525
deps:
* upgrade npm to 10.2.4 (npm team) #50751
* update archs files for openssl-3.0.13+quic1 (Node.js GitHub Bot) #51614
* upgrade openssl sources to quictls/openssl-3.0.13+quic1 (Node.js GitHub Bot) ://github.com//pull/51614
* fix GHSA-f74f-cvh7-c6q6/CVE-2024-24806 (Santiago Gimeno) #51614
http:
* add maximum chunk extension size (Paolo Insogna) nodejs-private/node-private#520
lib:
* update undici to v5.28.3 (Matteo Collina) nodejs-private/node-private#536
src:
* fix HasOnly(capability) in node::credentials (Tobias Nießen) nodejs-private/node-private#505
test:
* skip test-child-process-stdio-reuse-readable-stdio on Windows (Joyee Cheung) #49621
tools:
* add macOS notarization verification step (Ulises Gascón) #50833
* use macOS keychain to notarize the releases (Ulises Gascón) #50715
* remove unused file (Ulises Gascon) #50622
* add macOS notarization stapler (Ulises Gascón) #50625
* improve macOS notarization process output readability (Ulises Gascón) #50389
* remove unused `version` function (Ulises Gascón) #50390
win,tools:
* upgrade Windows signing to smctl (Stefan Stojanovic) #50956
zlib:
* pause stream if outgoing buffer is full (Matteo Collina) nodejs-private/node-private#542
PR-URL: nodejs-private/node-private#545
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
tools: remove unused file
ef79cb3
PR-URL: nodejs/node#50622
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
2024-02-14, Version 18.19.1 'Hydrogen' (LTS)
1ddeb10
This is a security release.
Notable changes:
crypto:
* update root certificates to NSS 3.95 (Node.js GitHub Bot) nodejs/node#50805
* disable PKCS#1 padding for privateDecrypt (Michael Dawson) https://github.com/nodejs-private/node-private/pull/525
deps:
* upgrade npm to 10.2.4 (npm team) nodejs/node#50751
* update archs files for openssl-3.0.13+quic1 (Node.js GitHub Bot) nodejs/node#51614
* upgrade openssl sources to quictls/openssl-3.0.13+quic1 (Node.js GitHub Bot) ://github.com/nodejs/node/pull/51614
* fix GHSA-f74f-cvh7-c6q6/CVE-2024-24806 (Santiago Gimeno) nodejs/node#51614
http:
* add maximum chunk extension size (Paolo Insogna) https://github.com/nodejs-private/node-private/pull/520
lib:
* update undici to v5.28.3 (Matteo Collina) https://github.com/nodejs-private/node-private/pull/536
src:
* fix HasOnly(capability) in node::credentials (Tobias Nießen) https://github.com/nodejs-private/node-private/pull/505
test:
* skip test-child-process-stdio-reuse-readable-stdio on Windows (Joyee Cheung) nodejs/node#49621
tools:
* add macOS notarization verification step (Ulises Gascón) nodejs/node#50833
* use macOS keychain to notarize the releases (Ulises Gascón) nodejs/node#50715
* remove unused file (Ulises Gascon) nodejs/node#50622
* add macOS notarization stapler (Ulises Gascón) nodejs/node#50625
* improve macOS notarization process output readability (Ulises Gascón) nodejs/node#50389
* remove unused `version` function (Ulises Gascón) nodejs/node#50390
win,tools:
* upgrade Windows signing to smctl (Stefan Stojanovic) nodejs/node#50956
zlib:
* pause stream if outgoing buffer is full (Matteo Collina) https://github.com/nodejs-private/node-private/pull/542
PR-URL: https://github.com/nodejs-private/node-private/pull/545
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
tools: remove unused file
99a8f43
PR-URL: nodejs/node#50622
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
2024-02-14, Version 18.19.1 'Hydrogen' (LTS)
d02cd45
This is a security release.
Notable changes:
crypto:
* update root certificates to NSS 3.95 (Node.js GitHub Bot) nodejs/node#50805
* disable PKCS#1 padding for privateDecrypt (Michael Dawson) https://github.com/nodejs-private/node-private/pull/525
deps:
* upgrade npm to 10.2.4 (npm team) nodejs/node#50751
* update archs files for openssl-3.0.13+quic1 (Node.js GitHub Bot) nodejs/node#51614
* upgrade openssl sources to quictls/openssl-3.0.13+quic1 (Node.js GitHub Bot) ://github.com/nodejs/node/pull/51614
* fix GHSA-f74f-cvh7-c6q6/CVE-2024-24806 (Santiago Gimeno) nodejs/node#51614
http:
* add maximum chunk extension size (Paolo Insogna) https://github.com/nodejs-private/node-private/pull/520
lib:
* update undici to v5.28.3 (Matteo Collina) https://github.com/nodejs-private/node-private/pull/536
src:
* fix HasOnly(capability) in node::credentials (Tobias Nießen) https://github.com/nodejs-private/node-private/pull/505
test:
* skip test-child-process-stdio-reuse-readable-stdio on Windows (Joyee Cheung) nodejs/node#49621
tools:
* add macOS notarization verification step (Ulises Gascón) nodejs/node#50833
* use macOS keychain to notarize the releases (Ulises Gascón) nodejs/node#50715
* remove unused file (Ulises Gascon) nodejs/node#50622
* add macOS notarization stapler (Ulises Gascón) nodejs/node#50625
* improve macOS notarization process output readability (Ulises Gascón) nodejs/node#50389
* remove unused `version` function (Ulises Gascón) nodejs/node#50390
win,tools:
* upgrade Windows signing to smctl (Stefan Stojanovic) nodejs/node#50956
zlib:
* pause stream if outgoing buffer is full (Matteo Collina) https://github.com/nodejs-private/node-private/pull/542
PR-URL: https://github.com/nodejs-private/node-private/pull/545
aduh95 pushed a commit to aduh95/node that referenced this pull request Feb 18, 2025
@UlisesGascon@marco-ippolito
tools: remove unused file
31f1ceb
PR-URL: nodejs#50622
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
aduh95 pushed a commit to aduh95/node that referenced this pull request Feb 18, 2025
@marco-ippolito@RafaelGSS
2024-02-14, Version 18.19.1 'Hydrogen' (LTS)
6610cc4
This is a security release.
Notable changes:
crypto:
* update root certificates to NSS 3.95 (Node.js GitHub Bot) nodejs#50805
* disable PKCS#1 padding for privateDecrypt (Michael Dawson) nodejs-private/node-private#525
deps:
* upgrade npm to 10.2.4 (npm team) nodejs#50751
* update archs files for openssl-3.0.13+quic1 (Node.js GitHub Bot) nodejs#51614
* upgrade openssl sources to quictls/openssl-3.0.13+quic1 (Node.js GitHub Bot) ://github.com/nodejs/pull/51614
* fix GHSA-f74f-cvh7-c6q6/CVE-2024-24806 (Santiago Gimeno) nodejs#51614
http:
* add maximum chunk extension size (Paolo Insogna) nodejs-private/node-private#520
lib:
* update undici to v5.28.3 (Matteo Collina) nodejs-private/node-private#536
src:
* fix HasOnly(capability) in node::credentials (Tobias Nießen) nodejs-private/node-private#505
test:
* skip test-child-process-stdio-reuse-readable-stdio on Windows (Joyee Cheung) nodejs#49621
tools:
* add macOS notarization verification step (Ulises Gascón) nodejs#50833
* use macOS keychain to notarize the releases (Ulises Gascón) nodejs#50715
* remove unused file (Ulises Gascon) nodejs#50622
* add macOS notarization stapler (Ulises Gascón) nodejs#50625
* improve macOS notarization process output readability (Ulises Gascón) nodejs#50389
* remove unused `version` function (Ulises Gascón) nodejs#50390
win,tools:
* upgrade Windows signing to smctl (Stefan Stojanovic) nodejs#50956
zlib:
* pause stream if outgoing buffer is full (Matteo Collina) nodejs-private/node-private#542
PR-URL: nodejs-private/node-private#545
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@targostargostargos approved these changes
@tniessentniessentniessen approved these changes
@richardlaurichardlaurichardlau approved these changes
@MoLowMoLowMoLow approved these changes
@himself65himself65himself65 approved these changes
+1 more reviewer
@mhdawsonmhdawsonmhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

macosIssues and PRs related to the macOS platform / OSX.toolsIssues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@UlisesGascon@mhdawson@lpinca@targos@tniessen@richardlau@MoLow@himself65@nodejs-github-bot