Skip to content

test_runner: pass abortSignal to test files - #50630

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
MoLow:pass-abort-signal
Nov 10, 2023
Merged

test_runner: pass abortSignal to test files#50630
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
MoLow:pass-abort-signal

Conversation

@MoLow

@MoLowMoLow commented Nov 8, 2023

Copy link
Copy Markdown
Member

Fixes: #50583

@nodejs-github-bot

nodejs-github-bot commented Nov 8, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Nov 8, 2023
@debadree25debadree25 added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 9, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 9, 2023
@nodejs-github-bot

nodejs-github-bot commented Nov 9, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55508/

@atlowChemiatlowChemi added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 9, 2023
@MoLowMoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 9, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 10, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 3cce03a into nodejs:mainNov 10, 2023
@nodejs-github-bot

nodejs-github-bot commented Nov 10, 2023

Copy link
Copy Markdown
Collaborator

Landed in 3cce03a

targos pushed a commit that referenced this pull request Nov 11, 2023
@MoLow@targos
test_runner: pass abortSignal to test files
73d13b8
PR-URL: #50630Fixes: #50583
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@MoLow
MoLow deleted the pass-abort-signal branch November 12, 2023 07:14
@targostargos mentioned this pull request Nov 12, 2023
Merged
targos pushed a commit that referenced this pull request Nov 14, 2023
@MoLow@targos
test_runner: pass abortSignal to test files
01bed64
PR-URL: #50630Fixes: #50583
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@MoLow@UlisesGascon
test_runner: pass abortSignal to test files
2c72ed8
PR-URL: #50630Fixes: #50583
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@UlisesGasconUlisesGascon mentioned this pull request Dec 12, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamingrbenjamingrbenjamingr approved these changes
@atlowChemiatlowChemiatlowChemi approved these changes
+1 more reviewer
@debadree25debadree25debadree25 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.test_runnerIssues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

node:test run does not respect abort signal

5 participants

@MoLow@nodejs-github-bot@benjamingr@debadree25@atlowChemi