Skip to content

fs: fix to not return for void function - #50769

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
pluris:fix/return_void_fs
Nov 24, 2023
Merged

fs: fix to not return for void function#50769
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
pluris:fix/return_void_fs

Conversation

@pluris

@plurispluris commented Nov 17, 2023

Copy link
Copy Markdown
Contributor

APIs with return type defined as void in jsdoc and document have been modified to not return a value.

@nodejs-github-botnodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Nov 17, 2023
@anonrig

anonrig commented Nov 17, 2023

Copy link
Copy Markdown
Member

Can you make sure your commit follows the recommended commit guidelines?

@plurispluris changed the title fs: fixed to not return for void functionfs: fix to not return for void functionNov 17, 2023
@pluris

pluris commented Nov 17, 2023

Copy link
Copy Markdown
ContributorAuthor

@anonrig I made a mistake. Thank you I fixed it.

@anonriganonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 17, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 17, 2023
@nodejs-github-bot

nodejs-github-bot commented Nov 17, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55718/

@nodejs-github-bot

nodejs-github-bot commented Nov 21, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55807/

@lpincalpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 24, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 24, 2023
@nodejs-github-bot
nodejs-github-bot merged commit ec79232 into nodejs:mainNov 24, 2023
@nodejs-github-bot

nodejs-github-bot commented Nov 24, 2023

Copy link
Copy Markdown
Collaborator

Landed in ec79232

lucshi pushed a commit to lucshi/node that referenced this pull request Nov 27, 2023
Jungku LeeLei Shi
fs: fix to not return for void function
5b17fc9
PR-URL: nodejs#50769
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
RafaelGSS pushed a commit that referenced this pull request Nov 27, 2023
Jungku Lee@RafaelGSS
fs: fix to not return for void function
c09be09
PR-URL: #50769
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
@RafaelGSSRafaelGSS mentioned this pull request Nov 28, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 29, 2023
Jungku Lee@RafaelGSS
fs: fix to not return for void function
45b2bb0
PR-URL: #50769
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
Jungku Lee@UlisesGascon
fs: fix to not return for void function
c9761df
PR-URL: #50769
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
@UlisesGasconUlisesGascon mentioned this pull request Dec 12, 2023
Merged
UlisesGascon pushed a commit that referenced this pull request Dec 13, 2023
Jungku Lee@UlisesGascon
fs: fix to not return for void function
986183b
PR-URL: #50769
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
UlisesGascon pushed a commit that referenced this pull request Dec 15, 2023
Jungku Lee@UlisesGascon
fs: fix to not return for void function
55b8e48
PR-URL: #50769
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
UlisesGascon pushed a commit that referenced this pull request Dec 19, 2023
Jungku Lee@UlisesGascon
fs: fix to not return for void function
cada22e
PR-URL: #50769
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes
@anonriganonriganonrig approved these changes
@Ayase-252Ayase-252Ayase-252 approved these changes
@KhafraDevKhafraDevKhafraDev approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.fsIssues and PRs related to the fs subsystem / file system.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@pluris@anonrig@nodejs-github-bot@jasnell@lpinca@Ayase-252@KhafraDev