Skip to content

test: replace forEach with for of in file test-trace-events-net.js - #50789

Closed
Ianna83 wants to merge 1 commit into
nodejs:mainfrom
Ianna83:master
Closed

test: replace forEach with for of in file test-trace-events-net.js#50789
Ianna83 wants to merge 1 commit into
nodejs:mainfrom
Ianna83:master

Conversation

@Ianna83

@Ianna83Ianna83 commented Nov 18, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 18, 2023
@marco-ippolitomarco-ippolito added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 18, 2023
@marco-ippolitomarco-ippolito added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Nov 20, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 20, 2023
@nodejs-github-bot

nodejs-github-bot commented Nov 20, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55787/

@nodejs-github-bot

nodejs-github-bot commented Nov 21, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55820/

@RafaelGSSRafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 24, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 24, 2023
@nodejs-github-bot

nodejs-github-bot commented Nov 24, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55891/

@nodejs-github-bot

nodejs-github-bot commented Dec 15, 2023•
edited by jasnell
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56308/ 💛

@jasnell

jasnell commented Dec 22, 2023

Copy link
Copy Markdown
Member

Landed in aa7de74

@jasnelljasnell closed this Dec 22, 2023
jasnell pushed a commit that referenced this pull request Dec 22, 2023
@Ianna83@jasnell
test: replace forEach with for of in file test-trace-events-net.js
aa7de74
PR-URL: #50789
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Jan 2, 2024
@Ianna83@RafaelGSS
test: replace forEach with for of in file test-trace-events-net.js
38232d1
PR-URL: #50789
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request Jan 2, 2024
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@Ianna83@richardlau
test: replace forEach with for of in file test-trace-events-net.js
c3c2b2b
PR-URL: #50789
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@richardlaurichardlau mentioned this pull request Mar 25, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes
@marco-ippolitomarco-ippolitomarco-ippolito approved these changes

Assignees

No one assigned

Labels

code-and-learnIssues related to the Code-and-Learn events and PRs submitted during the events.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Ianna83@nodejs-github-bot@jasnell@lpinca@marco-ippolito@RafaelGSS